private void buttonParseProcommD2M_Click(object sender, EventArgs e)
        {

            if (procommFile.Text == null || !procommFile.Text.EndsWith(".xls"))
            {
                MessageBox.Show("Please select a valid report file first!", "Error", MessageBoxButtons.OK, 
		MessageBoxIcon.Error);
            }
            else
            {
                // Ensure the program does not run multiple times unnecessarily from user error
                buttonParseProcommD2M.Hide();

                progressBarD2M1.Show();

                statusTextD2M.Text = "Parsing...";

                string thisSystem = "D2M";

                // Start Parsing
                openReport(thisSystem);
            }
	}

	private void openReport(string whatSystemIsIt)
        {
            //whatSystemIsIt is to identify if it is Amazon, LPSD, etc.

            // Start Excel
            Excel.Application xlApp;
            Excel.Workbook xlWorkBook;
            Excel.Worksheet xlWorkSheet;
            object misValue = System.Reflection.Missing.Value;

            xlApp = new Excel.Application();
            xlWorkBook = xlApp.Workbooks.Open(textBoxReportFile.Text,
		 0, 
		 true, 
		 5, "", "", 
		 true,
		 Microsoft.Office.Interop.Excel.XlPlatform.xlWindows,
		 "\t", false, false, 0, true, 1, 0);
            xlWorkSheet = (Excel.Worksheet)xlWorkBook.Worksheets.get_Item(1);

	    // Parse Procomm data into an array to manipulate
	    // Consider using 'Task Parallel' in future update
            for (int i = 9; i < 12000; i++)
            {
                // Excel Columns A & C from ProComm represent SKU & Inventory Quantity
		// Start with excel columns A(i), C(i) and move on
                string columnA = "A" + i;
                string columnC = "C" + i;

                // Update status bar, update per 10 to keep graphics update smooth on a single thread app
                if (i % 10 == 0)
                {
                    if (whatSystemIsIt == "Amazon")
                    {
                        progressBarAmazon.Value = i;
                    }
                    else if (whatSystemIsIt == "LPSD")
                    {
                        progressBarLPSD.Value = i;
                    }
                    else if (whatSystemIsIt == "D2M")
                    {
                        progressBarD2M.Value = i;
                    }
                }

                // Ensure that we don't try to bind a null/blank cell
                if (xlWorkSheet.get_Range(columnA, columnA).Value != null && 
		xlWorkSheet.get_Range(columnC, columnC).Value != null)
                {
                    // Put the found SKU cell data into a workable format
                    string procommSkuAndInventory = xlWorkSheet.get_Range(columnA, columnA).Value2.ToString();

                    // Only proceed if the cell SKU has a "-" (All products from the past 17 years have dashes)
		    // Get data
                    if (procommSkuAndInventoryCount.Contains('-'))
                    {
			// Add inventory data
                        procommSkuAndInventory += '\t' + xlWorkSheet.get_Range(columnC, columnC).Value2.ToString();
                        // Store excel data in the global array from earlier
                        procommSkuAndInventoryArray[i] = procommSkuAndInventory;
                    }
                }
            }

            // Clean up
            xlWorkBook.Close(true, misValue, misValue);
            xlApp.Quit();

            releaseObject(xlWorkSheet);
            releaseObject(xlWorkBook);
            releaseObject(xlApp);

            // Appropriate labels to give feedback to users 
            // Hide all progress bars since the procomm file does not need to be run for each system
            //Amazon
            labelAmazonParseProcomm.Text = "2) Parse Pro Comm Report";
            labelAmazonParseProcomm.ForeColor = Color.Silver;
            progressBarAmazon.Visible = false;
            progressBarAmazon.Value = 0;
            pictureBoxCheckBoxAmazon1.Visible = true;

            //LPSD
            labelLPSDParseProcomm.Text = "2) Parse Pro Comm Report";
            labelLPSDParseProcomm.ForeColor = Color.Silver;
            progressBarLPSD1.Visible = false;
            progressBarLPSD1.Value = 0;
            pictureBoxCheckBoxLPSD1.Visible = true;

            //D2M
            labelD2MParseProcomm.Text = "2) Parse Pro Comm Report";
            labelD2MParseProcomm.ForeColor = Color.Silver;
            progressBarD2M.Visible = false;
            progressBarD2M.Value = 0;
            pictureBoxCheckBoxD2M1.Visible = true;

        }

Knyteguy fucked around with this message at 21:31 on Sep 25, 2012

epswing fucked around with this message at 23:52 on Sep 25, 2012

• You're not separating your concerns. Presentation logic and application logic should not be mixed. This is a huge problem -- it shows that either you lack a fundamental understanding of object oriented programming (which is bad), or that you don't give a poo poo about doing it right (which is worse).
  
• Where are your unit tests? How do you know your application functions properly? How do you know that you're not breaking existing functionality when making changes? Having unit tests earns you points with a lot of employers. It certainly does with me!
  
• You do not follow Microsoft's naming conventions. I'm a stickler for this one, especially in sample code. Other people will tell you it doesn't matter, but my position is that Microsoft took the trouble to create a style guide, it makes a lot of sense, and there are lots of tools that can help enforce it. If you have a good reason for not following the guide and can articulate it and convince me, that's fine. If you don't have a good reason, then I chalk it up to sloppiness and/or not giving a poo poo.
  

epswing fucked around with this message at 01:48 on Sep 26, 2012

wwb fucked around with this message at 01:53 on Sep 26, 2012

<?xml version="1.0" encoding="UTF-8"?>
<configuration>
	<configSections>
		<section name="SomeConfigSource" blah blah blah/>
<!-- etc -->
	</configSections>
<!-- etc -->
	<SomeConfigSource application="bin\Moar.config" />
<configuration/>

<?xml version="1.0"?>
<configuration xmlns:xdt="http://schemas.microsoft.com/XML-Document-Transform">
	<SomeConfigSource xdt:Transform="Replace" application="C:\Long\Path\To\My\Local\bin\Moar.config"/>
</configuration>

Munkeymon fucked around with this message at 17:52 on Sep 28, 2012