Coding Horrors: You can gather all your technical debt into one easy framework!

Register a SA Forums Account here!
JOINING THE SA FORUMS WILL REMOVE THIS BIG AD, THE ANNOYING UNDERLINED ADS, AND STUPID INTERSTITIAL ADS!!!

You can: log in, read the tech support FAQ, or request your lost password. This dumb message (and those ads) will appear on every screen until you register! Get rid of this crap by registering your own SA Forums Account and joining roughly 150,000 Goons, for the one-time price of $9.95! We charge money because it costs us money per month for bills, and since we don't believe in showing ads to our users, we try to make the money back through forum registrations.

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > The Cavern of COBOL > Coding Horrors: You can gather all your technical debt into one easy framework!

cowboy beepboop: Feb 24, 2001

SuperGoon posted:

Here is a gem I uncovered today in a code review. This was written by an H-1B contractor. He has a masters degree and makes more than me. :[
code:
String s = httpServletRequest.getParameter("something");

if(s.trim().length() == 0 || s.equals(null)) {
    //do something
}
sigh...

Can you explain why it's stupid? Looks okay to me :haw:

# ¿ Apr 8, 2008 07:19

Adbot: ADBOT LOVES YOU

# ¿ Apr 27, 2024 22:43

cowboy beepboop: Feb 24, 2001

floWenoL posted:

What happens when s is null?

Haha oh I see.

# ¿ Apr 8, 2008 12:27

cowboy beepboop: Feb 24, 2001

code:

<?php


echo <<<EOF
</body>
</html>
EOF;

?>

# ¿ Apr 16, 2014 03:32

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > The Cavern of COBOL > Coding Horrors: You can gather all your technical debt into one easy framework!