Register a SA Forums Account here!
JOINING THE SA FORUMS WILL REMOVE THIS BIG AD, THE ANNOYING UNDERLINED ADS, AND STUPID INTERSTITIAL ADS!!!

You can: log in, read the tech support FAQ, or request your lost password. This dumb message (and those ads) will appear on every screen until you register! Get rid of this crap by registering your own SA Forums Account and joining roughly 150,000 Goons, for the one-time price of $9.95! We charge money because it costs us money per month for bills, and since we don't believe in showing ads to our users, we try to make the money back through forum registrations.
 
  • Locked thread
Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

ewe2 posted:

Ok hold the celebrations. For some reason, Quick reply works fine in THIS thread, when I went back to another thread, the problem returned, this is the console output


I'll double-check by killing the tab and restarting and see if something needed clearing.

edit: no that's not it. And I'm noticing that several other threads I have bookmarked are fine and others arent. Both the thread notes bar and the page navigator typically disappear in affected threads, but I'm not sure what setting might be causing this.

edit: edit: I figured it out. The issue is being triggered by ignored posts. If i click on the link to unignore a post, the functionality returns. I tested removing a user from the ignore list and the thread page comes up properly. Tested it on a different thread with an ignored post, and its repeatable.
Fixed. It's because the user notes function basically assumes every post will have the "Profile" button, and when the post doesn't, it breaks. Will release the update shortly after checking out the anchoring issue. Released 2.1.0.2 which has the fix. Really should make more use of that fourth number in the future for very tiny bug fixes between minor releases!

Let me know if anything else breaks with the user notes!

hooah posted:

The PYF Funny Pictures thread is where I've noticed it in the last day or two.
What are your image settings? Are you using the one that resizes images?

e: if it is just this, then I believe I should have a fix for this recycling the old anchoring code that was in SALR before and to implement it I get to use a thing in jQuery I didn't know existed! Pushed out 2.1.0.3 to see if it's fixed.

Master_Odin fucked around with this message at 06:59 on Mar 13, 2014

Adbot
ADBOT LOVES YOU

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies
2.1.0.3 released. re-anchors threads if you enable option to resize pictures. Hopefully that was what hooah is using, if not, I need a settings dump.

ewe2
Jul 1, 2009

Master_Odin posted:

Fixed. It's because the user notes function basically assumes every post will have the "Profile" button, and when the post doesn't, it breaks. Will release the update shortly after checking out the anchoring issue. Released 2.1.0.2 which has the fix. Really should make more use of that fourth number in the future for very tiny bug fixes between minor releases!

Let me know if anything else breaks with the user notes!

Thanks, it seems to be working, notes are being saved across threads ok. Code is a darned funny thing sometimes. I think the numbering system is a goer too.

hooah
Feb 6, 2006
WTF?

Master_Odin posted:

2.1.0.3 released. re-anchors threads if you enable option to resize pictures. Hopefully that was what hooah is using, if not, I need a settings dump.

I'm not using that option, and I've also noticed it happening in non-picture threads (PYF Flash Game most recently). Here's my settings dump:

SALR Configuration

Key Value
setting['MouseActiveContext'] = "false;"
setting['bottomNavBar'] = "true;"
setting['boxQuotes'] = "false;"
setting['collapseTldrQuotes'] = "true;"
setting['darkNewReplies'] = "#99cc99;"
setting['darkRead'] = "#6699cc;"
setting['displayConfigureSalr'] = "true;"
setting['displayCustomButtons'] = "false;"
setting['displayNewPostsFirst'] = "true;"
setting['displayNewPostsFirstForum'] = "true;"
setting['displayNewPostsFirstUCP'] = "true;"
setting['displayOmnibarIcon'] = "false;"
setting['displayPageNavigator'] = "false;"
setting['dontReplaceLinkImage'] = "true;"
setting['dontReplaceLinkNWS'] = "true;"
setting['dontReplaceLinkRead'] = "true;"
setting['dontReplaceLinkSpoiler'] = "true;"
setting['embedVideo'] = "true;"
setting['enableKeyboardShortcuts'] = "false;"
setting['enableMouseGestures'] = "false;"
setting['enableMouseMenu'] = "true;"
setting['enableMouseUpUCP'] = "false;"
setting['enableQuickReply'] = "true;"
setting['enableSOAPLink'] = "true;"
setting['enableSinglePost'] = "true;"
setting['enableThreadNotes'] = "false;"
setting['enableUserNotes'] = "false;"
setting['enableUserNotesSync'] = "true;"
setting['fixCancer'] = "true;"
setting['fixImgurLinks'] = "true;"
setting['hideAdvertisements'] = "true;"
setting['hidePostButtonInThread'] = "true;"
setting['highlightAdminColor'] = "#ff7256;"
setting['highlightFriends'] = "true;"
setting['highlightFriendsColor'] = "#f2babb;"
setting['highlightModAdmin'] = "true;"
setting['highlightModAdminUsername'] = "true;"
setting['highlightModeratorColor'] = "#b4eeb4;"
setting['highlightOP'] = "true;"
setting['highlightOPColor'] = "#fff2aa;"
setting['highlightOwnQuotes'] = "true;"
setting['highlightOwnUsername'] = "true;"
setting['highlightSelf'] = "true;"
setting['highlightSelfColor'] = "#f2babb;"
setting['highlightThread'] = "true;"
setting['hightlightThread'] = "false;"
setting['ignoreBookmarkStarGold'] = "false;"
setting['ignoreBookmarkStarRed'] = "false;"
setting['ignoreBookmarkStarYellow'] = "false;"
setting['inlinePostCounts'] = "false;"
setting['inlineVideo'] = "true;"
setting['lightNewReplies'] = "#ccffcc;"
setting['lightRead'] = "#99ccff;"
setting['openAllUnreadLink'] = "true;"
setting['postsPerPage'] = "default;"
setting['qneProtection'] = "true;"
setting['quickReplyBookmark'] = "true;"
setting['quickReplyDisableSmilies'] = "false;"
setting['quickReplyEmotes'] = "true;"
setting['quickReplyFormat'] = "true;"
setting['quickReplyLivePreview'] = "false;"
setting['quickReplyParseUrls'] = "true;"
setting['quickReplySignature'] = "false;"
setting['removeOwnReport'] = "true;"
setting['replaceImagesLink'] = "true;"
setting['replaceImagesReadOnly'] = "true;"
setting['replaceImagesWithLinks'] = "true;"
setting['replaceLinksWithImages'] = "true;"
setting['restrictImagePxH'] = "800;"
setting['restrictImagePxW'] = "800;"
setting['restrictImageSize'] = "false;"
setting['retinaImages'] = "false;"
setting['salrInitialized'] = "true;"
setting['salrLogoHide'] = "false;"
setting['searchThreadHide'] = "true;"
setting['setImageTooltip'] = "true;"
setting['setImageTooltipBlankOnly'] = "true;"
setting['setImageTooltipHideExtension'] = "true;"
setting['setImageTooltipHideSourceUrl'] = "true;"
setting['setImageTooltipSkipEmoticons'] = "true;"
setting['showEditBookmarks'] = "false;"
setting['showLastThreePages'] = "false;"
setting['showLastThreePagesForum'] = "true;"
setting['showLastThreePagesThread'] = "true;"
setting['showLastThreePagesUCP'] = "true;"
setting['showNavigation'] = "true;"
setting['showPurchases'] = "true;"
setting['showUserAvatar'] = "true;"
setting['showUserAvatarImage'] = "true;"
setting['threadCaching'] = "false;"
setting['topForumRules'] = "true;"
setting['topGloryhole'] = "true;"
setting['topLepersColony'] = "true;"
setting['topLogout'] = "true;"
setting['topNavBar'] = "true;"
setting['topPrivMsgs'] = "false;"
setting['topPurchaseAcc'] = "false;"
setting['topPurchaseArchives'] = "true;"
setting['topPurchaseAva'] = "true;"
setting['topPurchaseBannerAd'] = "false;"
setting['topPurchaseEmoticon'] = "false;"
setting['topPurchaseGiftCert'] = "false;"
setting['topPurchaseNoAds'] = "false;"
setting['topPurchasePlat'] = "true;"
setting['topPurchaseSticky'] = "false;"
setting['topPurchaseUsername'] = "false;"
setting['topSAForums'] = "true;"
setting['topSALink'] = "true;"
setting['topSaclopedia'] = "true;"
setting['topSearch'] = "true;"
setting['topSupport'] = "true;"
setting['topUserCP'] = "true;"
setting['userQuote'] = "#a2cd5a;"
setting['username'] = "hooah;"
setting['usernameCase'] = "false;"
setting['usernameHighlight'] = "#9933ff;"
setting['whoPostedHide'] = "false;"
setting['youtubeHighlight'] = "#ff00ff;"

kri kri
Jul 18, 2007

Thanks for the updates. I am now getting the single post icon when viewing threads but the option is disabled.

SALR Configuration

Key Value
setting['MouseActiveContext'] = "false;"
setting['bottomNavBar'] = "true;"
setting['boxQuotes'] = "false;"
setting['collapseTldrQuotes'] = "false;"
setting['darkNewReplies'] = "#99cc99;"
setting['darkRead'] = "#6699cc;"
setting['displayConfigureSalr'] = "true;"
setting['displayCustomButtons'] = "false;"
setting['displayNewPostsFirst'] = "false;"
setting['displayNewPostsFirstForum'] = "true;"
setting['displayNewPostsFirstUCP'] = "true;"
setting['displayOmnibarIcon'] = "false;"
setting['displayPageNavigator'] = "false;"
setting['dontReplaceLinkImage'] = "false;"
setting['dontReplaceLinkNWS'] = "false;"
setting['dontReplaceLinkRead'] = "false;"
setting['dontReplaceLinkSpoiler'] = "false;"
setting['embedVideo'] = "false;"
setting['enableKeyboardShortcuts'] = "true;"
setting['enableMouseGestures'] = "false;"
setting['enableMouseMenu'] = "true;"
setting['enableMouseUpUCP'] = "false;"
setting['enableQuickReply'] = "true;"
setting['enableSOAPLink'] = "false;"
setting['enableSinglePost'] = "false;"
setting['enableThreadNotes'] = "false;"
setting['enableUserNotes'] = "true;"
setting['enableUserNotesSync'] = "true;"
setting['fixCancer'] = "false;"
setting['fixImgurLinks'] = "true;"
setting['hideAdvertisements'] = "false;"
setting['hidePostButtonInThread'] = "true;"
setting['highlightAdminColor'] = "#ff7256;"
setting['highlightFriends'] = "false;"
setting['highlightFriendsColor'] = "#f2babb;"
setting['highlightModAdmin'] = "false;"
setting['highlightModAdminUsername'] = "false;"
setting['highlightModeratorColor'] = "#b4eeb4;"
setting['highlightOP'] = "true;"
setting['highlightOPColor'] = "#fff2aa;"
setting['highlightOwnQuotes'] = "true;"
setting['highlightOwnUsername'] = "true;"
setting['highlightSelf'] = "true;"
setting['highlightSelfColor'] = "#f2babb;"
setting['hightlightThread'] = "false;"
setting['ignoreBookmarkStarGold'] = "false;"
setting['ignoreBookmarkStarRed'] = "false;"
setting['ignoreBookmarkStarYellow'] = "false;"
setting['inlinePostCounts'] = "false;"
setting['inlineVideo'] = "false;"
setting['lightNewReplies'] = "#ccffcc;"
setting['lightRead'] = "#99ccff;"
setting['openAllUnreadLink'] = "true;"
setting['postsPerPage'] = "default;"
setting['qneProtection'] = "false;"
setting['quickReplyBookmark'] = "false;"
setting['quickReplyDisableSmilies'] = "false;"
setting['quickReplyEmotes'] = "true;"
setting['quickReplyFormat'] = "true;"
setting['quickReplyLivePreview'] = "false;"
setting['quickReplyParseUrls'] = "false;"
setting['quickReplySignature'] = "false;"
setting['removeOwnReport'] = "true;"
setting['replaceImagesLink'] = "false;"
setting['replaceImagesReadOnly'] = "false;"
setting['replaceImagesWithLinks'] = "false;"
setting['replaceLinksWithImages'] = "false;"
setting['restrictImagePxH'] = "800;"
setting['restrictImagePxW'] = "800;"
setting['restrictImageSize'] = "false;"
setting['retinaImages'] = "false;"
setting['salrInitialized'] = "true;"
setting['salrLogoHide'] = "false;"
setting['saveUserNotes'] = "true;"
setting['searchThreadHide'] = "false;"
setting['setImageTooltip'] = "false;"
setting['setImageTooltipBlankOnly'] = "true;"
setting['setImageTooltipHideExtension'] = "true;"
setting['setImageTooltipHideSourceUrl'] = "true;"
setting['setImageTooltipSkipEmoticons'] = "true;"
setting['showEditBookmarks'] = "false;"
setting['showLastThreePages'] = "false;"
setting['showLastThreePagesForum'] = "true;"
setting['showLastThreePagesThread'] = "true;"
setting['showLastThreePagesUCP'] = "true;"
setting['showNavigation'] = "true;"
setting['showPurchases'] = "false;"
setting['showUserAvatar'] = "true;"
setting['showUserAvatarImage'] = "true;"
setting['threadCaching'] = "false;"
setting['topForumRules'] = "false;"
setting['topGloryhole'] = "false;"
setting['topLepersColony'] = "true;"
setting['topLogout'] = "false;"
setting['topNavBar'] = "true;"
setting['topPrivMsgs'] = "true;"
setting['topPurchaseAcc'] = "true;"
setting['topPurchaseArchives'] = "true;"
setting['topPurchaseAva'] = "true;"
setting['topPurchaseBannerAd'] = "true;"
setting['topPurchaseEmoticon'] = "true;"
setting['topPurchaseGiftCert'] = "true;"
setting['topPurchaseNoAds'] = "true;"
setting['topPurchasePlat'] = "true;"
setting['topPurchaseSticky'] = "true;"
setting['topPurchaseUsername'] = "true;"
setting['topSAForums'] = "true;"
setting['topSALink'] = "false;"
setting['topSaclopedia'] = "true;"
setting['topSearch'] = "true;"
setting['topSupport'] = "false;"
setting['topUserCP'] = "true;"
setting['userQuote'] = "#a2cd5a;"
setting['username'] = "kri kri;"
setting['usernameCase'] = "false;"
setting['usernameHighlight'] = "#9933ff;"
setting['whoPostedHide'] = "false;"
setting['youtubeHighlight'] = "#ff00ff;"

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

kri kri posted:

Thanks for the updates. I am now getting the single post icon when viewing threads but the option is disabled.
Whoops! Fixed in just released 2.1.0.4. Still need to look at the re-anchoring issue for hooah before 2.1.1 actual comes out (which will just be all these fixes wrapped into a release).

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies
Just uploaded 2.1.0.5 to the web store. Let me know if the anchoring issue is fixed. SALR will attempt to re-anchor the page if you use any of the image settings or the quote settings. Let me know if this helps as it seems to work well for me?

hooah
Feb 6, 2006
WTF?

Master_Odin posted:

Just uploaded 2.1.0.5 to the web store. Let me know if the anchoring issue is fixed. SALR will attempt to re-anchor the page if you use any of the image settings or the quote settings. Let me know if this helps as it seems to work well for me?

Seems to be working well so far, but haven't had many pictures in threads yet today. I'll post again if I notice it going wonky again.

TJChap2840
Sep 24, 2009
Sorry in advance if this is the wrong place.

Something Awful randomly started looking like this screenshot after a refresh. It stays like this regardless of having SALR enabled or disabled. No other website is having any CSS(?) issues.

chocolateTHUNDER
Jul 19, 2008

GIVE ME ALL YOUR FREE AGENTS

ALL OF THEM

TJChap2840 posted:

Sorry in advance if this is the wrong place.

Something Awful randomly started looking like this screenshot after a refresh. It stays like this regardless of having SALR enabled or disabled. No other website is having any CSS(?) issues.



I think somebody is just having a little fun with the css on the site at the moment.

crestfallen
Aug 2, 2009

Hi.
It does that on Firefox too. I can only think that maybe it's a really weird St. Patrick's Day/Irish thing? Otherwise somebody just hosed up.

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies
Yeah, the new style for "Demonius Darkblade's Retrogaming Dungeon" leaked out to the main forum but it appears things got fixed. It had nothing to do with SALR.

unpronounceable
Apr 4, 2010

You mean we still have another game to go through?!
Fallen Rib
Is there a reason some threads have the number of replies highlighted, but not others? It happens both in my user CP and normal forums, but I can't pin down why it's happening.



Settings dump

Javid
Oct 21, 2004

:jpmf:
Those are threads you have posted in since installing the extension (or updating it with that option or whatever)

unpronounceable
Apr 4, 2010

You mean we still have another game to go through?!
Fallen Rib

Javid posted:

Those are threads you have posted in since installing the extension (or updating it with that option or whatever)

I thought that might have been it, but I posted in a thread earlier today that didn't get highlighted. The thread, if it matters.

EDIT: Maybe it's because I posted on the first page in that thread?

Javid
Oct 21, 2004

:jpmf:
I don't know either. It's flaky for me too and I'll probably turn it off.

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies
So new update coming shortly as I think I've fixed the issue plaguing friend highlight getting the time it takes to complete down from (on a random page of this thread with a couple users being friends on that page):
40273.000ms
to
11.000ms

So it's usable again without a huge impact. :woop:

"Releasing" 2.1.1 in a tiny bit even though only the final bullet point isn't available to the public yet as I've been pushing things out incrementally for this one.

Changelog posted:

### v2.1.1 (3/30/2014)
```
+ Add page navigator to usercp/bookmarkthreads.php if more than two pages of bookmarks (will only show if more than one page)
+ Add mouse gestures for usercp/bookmarkthreads if more than one page
* Fix for user notes breaking SALR when you ignore a user
* Re-anchor window when adjusting anything that changes window size (quotes, images, etc.)
* Fix bug with single post button setting
* Fix horrible slowdown associated with friends highlighting
```

unpronounceable posted:

I thought that might have been it, but I posted in a thread earlier today that didn't get highlighted. The thread, if it matters.

EDIT: Maybe it's because I posted on the first page in that thread?
The only thing it has trouble with is if start a thread. Sort of hard to test that feature as not a great place to continuously start threads to test and work on. Otherwise, the event for adding it to the DB for coloring is bound to using the reply button in both the Quick Reply and the default Reply window. :(

Javid posted:

I don't know either. It's flaky for me too and I'll probably turn it off.
Where is it acting flaky?

Master_Odin fucked around with this message at 17:00 on Mar 30, 2014

Javid
Oct 21, 2004

:jpmf:
It highlights SOME threads I've posted in, but not all of them. I don't see the point anyway since I don't generally follow threads I'm not participating in so eventually they'll all be highlighted.

hooah
Feb 6, 2006
WTF?
For some reason my SALR is suddenly not working, as far as I can tell. No quick reply/quote, can't collapse long quotes, pages display further than they should after they finish loading. I've tried disabling and re-enabling the extension, but no difference. Should I try re-installing it yet?

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

hooah posted:

For some reason my SALR is suddenly not working, as far as I can tell. No quick reply/quote, can't collapse long quotes, pages display further than they should after they finish loading. I've tried disabling and re-enabling the extension, but no difference. Should I try re-installing it yet?
Options -> Tools -> Javascript Console and copy and paste what you see in it. Not sure why it would suddenly stop working as I'm actively using the same version with the code that I changed.

e: I think I may have failed to have things gracefully fail on the new way friends highlighting works so you do have to visit the usercp. I'll check that now. Should fail gracefully (in a way that won't kill salr) if you don't have your friends ids for friend post highlighting yet. (Need to visit the User CP to get them). Should see v2.1.1.1 in extensions list.

Master_Odin fucked around with this message at 05:26 on Apr 4, 2014

hooah
Feb 6, 2006
WTF?
Alright, here's the text in the JS console just after starting up Chrome and coming here:
code:
event.returnValue is deprecated. Please use the standard event.preventDefault() instead.
Failed to load resource: net::ERR_BLOCKED_BY_CLIENT           [url]http://edge.quantserve.com/quant.js?_=1396651491060[/url]
My SALR version just says 2.1.1, rather than 2.1.1.1, however. Also, I wouldn't think it would have anything to do with friends, since I don't use that part of SALR.

SALR updated itself, and is now working properly. Thanks?

hooah fucked around with this message at 00:30 on Apr 5, 2014

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

hooah posted:

Alright, here's the text in the JS console just after starting up Chrome and coming here:
code:
event.returnValue is deprecated. Please use the standard event.preventDefault() instead.
Failed to load resource: net::ERR_BLOCKED_BY_CLIENT           [url]http://edge.quantserve.com/quant.js?_=1396651491060[/url]
My SALR version just says 2.1.1, rather than 2.1.1.1, however. Also, I wouldn't think it would have anything to do with friends, since I don't use that part of SALR.

SALR updated itself, and is now working properly. Thanks?
If you're not using that part, I have no idea as that's the only thing I could think would potentially fail at the moment and neither of those are "breaking errors" (and the second one is definitely not from SALR). :iiam:

e: you were using friends highlighting! Essentially, I changed how it was being done (off of userid instead of name as it's faster to just run through all posts then filter heavily on contains) and things would be undefined if you hadn't visited UserCP since the update. Should work though after that just fine (and way way faster!)

Master_Odin fucked around with this message at 05:03 on Apr 7, 2014

Rinkles
Oct 24, 2010

What I'm getting at is...
Do you feel the same way?
The dotted lines around images aren't intentional, correct?



They appear if image resizing is checked, and regardless of whether the image was actually resized or not.

pik_d
Feb 24, 2006

follow the white dove





TRP Post of the Month October 2021
Hitting 'J' doesn't take me to the next page in subforums, but it still works in threads. Is this just me or has this broken for everyone?

Dr.Caligari
May 5, 2005

"Here's a big, beautiful avatar for someone"
sorry, wrong thread

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies
v2.1.2 should fix the above issues.

CHANGELOG posted:

### v2.1.2 (4/14/2014)
```
* Fix SALR crash when using Post Cout Highlighting on forum page with global announcement
* Fix logic on image resizing
```

e: test

test me

twitter link

https://twitter.com/lowtax/status/464723696108576768

http://zippy.gfycat.com/UnequaledPowerlessEmperorshrimp.webm

https://vine.co/v/Min9wlMKh9M

Master_Odin fucked around with this message at 07:08 on May 11, 2014

ClassActionFursuit
Mar 15, 2006

I don't know if you're aware but there's a thread over in YOSPOS about a Chrome SA extension that has a couple really cool features (and a few I don't want). Maybe some should be included in SALR?

The couple I'm thinking of specifically are:
  • Tweet embed - links to Tweets are now turned into a fully interactive embed of the tweet. It is then cached so that if it is deleted on Twitter then it will still display on the forums when you refresh the page etc
  • Embed vine and webm video - any webm url in a post will be embedded with sound turned off by default, set to autoplay and set to loop
Another thing included in it that you might want to put into SALR regardless is a fix for the maximize button being missing on the YouTube HTML5 player which this post here explains what's needed.

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies
Released Might release (or might just hold off for a bit longer to incorporate a couple more bug fixes) v2.1.2.1 which fixes embed youtube videos posted using the [video] tab not being able to fullscreen as well as changed it so that all youtube url links always use the embed player (instead of potentially the iframe) so everything is the same everywhere.

Master_Odin fucked around with this message at 07:34 on May 10, 2014

ClassActionFursuit
Mar 15, 2006

Master_Odin posted:

Released Might release (or might just hold off for a bit longer to incorporate a couple more bug fixes) v2.1.2.1 which fixes embed youtube videos posted using the [video] tab not being able to fullscreen as well as changed it so that all youtube url links always use the embed player (instead of potentially the iframe) so everything is the same everywhere.
Was just going to ask about this and now I see the edit.

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

LastInLine posted:

Was just going to ask about this and now I see the edit.
Yeah, decided to hold off a couple days and incorporate a bit more into it. This should be out later today after I get up at some point and finalize testing. And hey, got both of your suggestions implemented (minus the twitter cache bit because dunno how useful it'd really be and creates a divide between users so you don't realize it's been deleted, quote and then someone else is like "what the hell are you talking about?!" (I guess I could solve this with custom CSS, but again, how often are you looking at old tweets after you're past the current page?). I also don't have to worry about rate limiting and can make as many requests to the API as I want it seems so I shouldn't have to worry about getting banned from twitter or something).

CHANGELOG posted:

### v2.1.3 (5/12/2014)
```
+ Allow tweet links to show up inline
+ Allow vine links to show up inline
+ Allow webm (gfycat) links to show up inline
* Fix embed youtube videos not having fullscreen button
* Have all inline videos from links use HTML5 player (no more flash)
* Fix "Jump to another forum" appearing in Omnibar (and Chrome Button extension) jump list
* Improve first usage of "Quick Reply" if user had just installed SALR and hadn't visited "newreply.php" yet
```


Slowly working on trying to the imgur uploading back into SALR at the moment. Having major issues with drag and drop though. :(

ClassActionFursuit
Mar 15, 2006

Master_Odin posted:

(minus the twitter cache bit because dunno how useful it'd really be and creates a divide between users so you don't realize it's been deleted, quote and then someone else is like "what the hell are you talking about?!" (I guess I could solve this with custom CSS, but again, how often are you looking at old tweets after you're past the current page?). I also don't have to worry about rate limiting and can make as many requests to the API as I want it seems so I shouldn't have to worry about getting banned from twitter or something).
The idea behind the caching is that the best tweets get deleted but that's what screenshots are for.

Javid
Oct 21, 2004

:jpmf:
Can we turn off the twitter bullshit so the extension doesn't need twitter permissions?

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

Javid posted:

Can we turn off the twitter bullshit so the extension doesn't need twitter permissions?
Sure, apparently you can have optional permissions so twitter and imgur are both optional (which only get requested if you turn on tweets/quick reply). v2.1.3.1 uploaded. If you don't have the option selected, it'll remove the permission automatically. If you have it selected and you deselect it, you'll lose the permission. On the first time you turn on the feature, you'll get a permission request.

Not that the twitter api gave me much. :v:

ClassActionFursuit
Mar 15, 2006

How do you use the imgur features?

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

LastInLine posted:

How do you use the imgur features?
By waiting for now. I was just preemptively moving it to the optional permissions along with the twitter api.

Master_Odin posted:

Slowly working on trying to the imgur uploading back into SALR at the moment. Having major issues with drag and drop though. :(

wormil
Sep 12, 2002

Hulk will smoke you!
edit; nm, I'm an idiot

wormil fucked around with this message at 19:24 on May 13, 2014

ClassActionFursuit
Mar 15, 2006

Master_Odin posted:

By waiting for now. I was just preemptively moving it to the optional permissions along with the twitter api.
Gotcha, I assumed because it was pushed that those got solved. Would having such a feature in SALR do anything for imgur always logging me out?

Flagrama
Jun 19, 2010

Lipstick Apathy
http://forums.somethingawful.com/showthread.php?threadid=2803713&userid=0&perpage=40&pagenumber=600

Even though I have Show User Avatar's Image disabled avatar images are showing up on this page. If you need any other information let me know.

Also, is there any way you could add that functionality to the post reply page as well?

Master_Odin
Apr 15, 2010

My spear never misses its mark...

ladies

LastInLine posted:

Gotcha, I assumed because it was pushed that those got solved. Would having such a feature in SALR do anything for imgur always logging me out?
No. SALR would use the Imgur API which has no relevance to whether or not you're logged in. It would never affect your account on the site.

Flagrama posted:

http://forums.somethingawful.com/showthread.php?threadid=2803713&userid=0&perpage=40&pagenumber=600

Even though I have Show User Avatar's Image disabled avatar images are showing up on this page. If you need any other information let me know.

Also, is there any way you could add that functionality to the post reply page as well?
Both of these are fixed in the new version of SALR which should come at some point this weekend.

Adbot
ADBOT LOVES YOU

dont be mean to me
May 2, 2007

I'm interplanetary, bitch
Let's go to Mars


The Forums are now rejecting submissions from the Quick Reply panel with their "no third-party posting" warning. (I checked the recent replies and I don't think this has been mentioned in here yet.)

Previewing and then submitting works fine, presumably because the preview page is a standard Forums page.

  • Locked thread