|
Flipperwaldt posted:Something weird is happening with the picture in the first post on this page: Looks like it's a slightly different symptom of the forum bug since last year - the related SALR issue on github has the same cause, too. The forums are inserting a broken link to an image that was removed from imgur, but imgur returns a valid image saying it was removed. Normally those broken image links redirect to things that aren't an image, which SALR detects and doesn't convert (this was our solution when the problem first showed up). However, since it's a valid image, SALR's link-to-image conversion is happily converting it. We may need to add an ugly hack for this after all. astral fucked around with this message at 20:33 on May 2, 2015 |
# ? May 2, 2015 20:28 |
|
|
# ? Apr 25, 2024 00:41 |
|
Looks like you need to make a special, non-converting case of linked images ?????ss, ?????tt, ?????ll, but only if they are an url link surrounding an img link to ?????s, ?????t, ?????l (where ????? is the same). Is that it?
|
# ? May 2, 2015 22:01 |
|
Flipperwaldt posted:Looks like you need to make a special, non-converting case of linked images ?????ss, ?????tt, ?????ll, but only if they are an url link surrounding an img link to ?????s, ?????t, ?????l (where ????? is the same). Yes, something like that. I committed a hacky workaround that will show up in the next build. As a result, some properly-formatted thumbnail links to full images will not be converted, but it was pretty much either that or query imgur's API each time this was encountered to see if they were the same image. e: Though, the more I think about it, an extra JSON request in such a rare case while the image conversion is already making all those extra requests for the new images anyway probably isn't that big a deal... astral fucked around with this message at 09:28 on May 3, 2015 |
# ? May 3, 2015 09:13 |
|
I found a bug in the youtube title scraper. It seems to be scraping the title of this video incorrectly: http://forums.somethingawful.com/showthread.php?action=showpost&postid=444940587&forumid=167 For me at least, it shows up like this: . Not sure what the problem might be, and it's the only video I've seen so far that's had a problem with the title scraper. Edit: found a couple more on this page: http://forums.somethingawful.com/showthread.php?noseen=0&threadid=3493510&perpage=40&pagenumber=85 Edit 2: it seems to be an issue with either youtube or SALR, because now all videos are being titled like that. Tried ctrl+f5, but they're still showing up like that. Using Firefox 37.0.2 in Ubuntu 14.04. Edit 3: restarting the browser didn't fix the issue. Schizophrenic Orb fucked around with this message at 19:41 on May 5, 2015 |
# ? May 5, 2015 19:09 |
|
Schizophrenic Orb posted:I found a bug in the youtube title scraper. It seems to be scraping the title of this video incorrectly: http://forums.somethingawful.com/showthread.php?action=showpost&postid=444940587&forumid=167 Thanks for testing this. Please visit this link and copy&paste the result into a [code] tag. I do have an idea of what might be happening already (YouTube is killing off the older version of its API for more devices), but having that output would be handy. e: After grabbing that output, feel free to try this test build which uses the newer YouTube API version. astral fucked around with this message at 22:42 on May 5, 2015 |
# ? May 5, 2015 21:20 |
|
astral posted:Thanks for testing this. Please visit this link and copy&paste the result into a code tag. I do have an idea of what might be happening already (YouTube is killing off the older version of its API for more devices), but having that output would be handy. code:
|
# ? May 6, 2015 00:21 |
|
I reset my Firefox yesterday and reinstalled the SALR extension (newest version). Now, regardless of what setting I choose, I don't see unread counts in the User CP (either on their own line or inline). I do have the "go to last post" button on threads with unread replies showing up. Also, when I try to use Quick Reply, I get this: edit: Testing quick reply edit edit: Quick Edit Works Now edit edit edit: and now my unread counts are back in the User CP
|
# ? May 6, 2015 17:08 |
|
v1.99.150505 Notes:
Recent notes: (v1.99.150430):
astral fucked around with this message at 01:55 on May 9, 2015 |
# ? May 6, 2015 23:59 |
|
v1.99.150506 Notes:
|
# ? May 7, 2015 09:57 |
|
Thanks so much for the Youtube titles; I had no idea I needed that so badly.
|
# ? May 8, 2015 17:23 |
|
astral posted:
Flipperwaldt posted:Thanks so much for the Youtube titles; I had no idea I needed that so badly. Neither did I. Thanks! It works wonderfully.
|
# ? May 8, 2015 22:25 |
|
v1.99.150508 Notes:
astral fucked around with this message at 07:44 on May 9, 2015 |
# ? May 9, 2015 07:42 |
|
Anyone else not getting embedded YouTube videos playiong at the resolution chosen in the SALR options I'm running v1.99.150508
|
# ? May 9, 2015 12:37 |
|
lovely Treat posted:Anyone else not getting embedded YouTube videos playiong at the resolution chosen in the SALR options Just checked into this and it looks like Google itself recently broke or disabled support for choosing resolutions ahead of time (neither the way SALR does it nor the way the forums embeds do it are currently working). I'll try to see if some new method of specifying resolution ahead of time has appeared over the years. e: Looks like it can be done through a different, slightly more complicated method. If the older method(s) don't fix themselves before too long, I'll try to set aside some time to work on implementing it. Google astral fucked around with this message at 20:28 on May 9, 2015 |
# ? May 9, 2015 20:17 |
|
astral posted:Just checked into this and it looks like Google itself recently broke or disabled support for choosing resolutions ahead of time (neither the way SALR does it nor the way the forums embeds do it are currently working). I'll try to see if some new method of specifying resolution ahead of time has appeared over the years. OK thanks for checking it out.
|
# ? May 9, 2015 20:55 |
|
v1.99.150513 Notes:
IMPORTANT FUTURE COMPATIBILITY NOTE: This is probably the last legacy extension update for SALR. Future versions will be restartless, updating and installing without requiring you to restart your browser each time. (Please note that when SALR updates to become restartless, Firefox will still have to restart once to properly disable the old legacy version.) The trade-off for all this is that really old browser versions will no longer be supported by SALR as of the next version. Tentatively, the minimum Firefox version we're going to claim to support will be Firefox 10.0. More information will be forthcoming. astral fucked around with this message at 00:05 on May 14, 2015 |
# ? May 13, 2015 23:36 |
|
http://forums.somethingawful.com/showthread.php?threadid=2920891&pagenumber=192 Got here an example of how the new handling for imgur's native thumbnails now apparently bypasses salr's own max width resizing thing, resulting in a table breaking picture in Don Lapre's post. It's not one of those super special ss, ll, tt cases, just a regular use of l linking to the fullsize picture. e: With the setting to convert links to pictures and resize pics to a max width of 1000px, of course.
|
# ? May 14, 2015 11:42 |
|
Flipperwaldt posted:http://forums.somethingawful.com/showthread.php?threadid=2920891&pagenumber=192 Good find; fixed that for the next version.
|
# ? May 14, 2015 12:10 |
|
I was also trying the "convert images to links in read posts" option and it seems to apply that to some but not all smilies. for one seems to get converted to a link then. There may be a reason for it, but it struck me as an unintended inconcistency. This could be a matter of adding another somethingawful server that apparently serves images to an array somewhere, in which case, wahey. Otherwise, never mind. Got me thinking about a feature request, I guess. Which is for an option for image links to also behave like youtube/webm links in the sense that they individually embed when you click on them. Like, I wouldn't set salr to convert all image links to embedded pictures automatically if I could embed on demand. The fact that clicking the salr created link to that emoticon took me away from the page was actually confusing for a moment, until I realized that, yes, that's how image links behave normally. That's how spoiled rotten the other embedding on demand has made me Would save on opening new tabs for links that didn't get converted for nws reasons, spot checking links created in read posts, not having to pre-load gigantic gifs or pics that were linked for file size and stuff like that and it makes sense to me for them to behave like other media inlining. Which is all just comfort and nothing else. Don't know if that idea strikes a chord with you. I would think technically the building blocks are already there, but I'm blind to the eventual complications, so whatever.
|
# ? May 14, 2015 14:07 |
|
Some smilies accidentally converting to links fixed for the next version. I admit to not using any of those image converting features, but that doesn't sound like a bad idea to me; most of the framework should indeed already be there. It would either need a different link background color than the videos to signify "this is an image link" or maybe a little image icon can be put in sort of like like the video icon - we even already have an image icon that we use in the quick post window. I'll make a note to look into it.
astral fucked around with this message at 21:02 on May 14, 2015 |
# ? May 14, 2015 20:55 |
|
Sweet. Thanks for your time, whatever comes of it.
|
# ? May 14, 2015 21:30 |
|
astral, will part of the changes to deprecate very old Firefox support include electrolysis support? My developer version just offered me the ability to enable it and I did, but it breaks SALR at the moment. This bums me out, I <3 SALR.
|
# ? May 16, 2015 23:07 |
|
Tivac posted:astral, will part of the changes to deprecate very old Firefox support include electrolysis support? My developer version just offered me the ability to enable it and I did, but it breaks SALR at the moment. This bums me out, I <3 SALR. I just tested and the legacy version of SALR works fine under Electrolysis with the compatibility shim in Nightly, but not Developer Edition. I'd guess some compatibility shim stuff didn't make it into Developer Edition or something. To more fully answer your question, though, and to give a bit of a status report: SALR natively supporting Electrolysis rather than using the shim would be ideal, for sure. So far I've got SALR working as a restartless addon and I've broken up the backend code from our one giant XPCOM component into several modules. After I finish tearing the last remaining bits of browser UI out of the old overlay script and putting them into the new UI module, I'll start looking at how SALR interacts with page content.
|
# ? May 17, 2015 00:14 |
|
astral posted:I just tested and the legacy version of SALR works fine under Electrolysis with the compatibility shim in Nightly, but not Developer Edition. I'd guess some compatibility shim stuff didn't make it into Developer Edition or something. I'm awful glad you're in charge of SALR development now, I only understand about half of that & I contributed code to SALR once upon a time! XD
|
# ? May 17, 2015 05:17 |
|
Tivac posted:astral, will part of the changes to deprecate very old Firefox support include electrolysis support? My developer version just offered me the ability to enable it and I did, but it breaks SALR at the moment. This bums me out, I <3 SALR. I looked into this some more and it looks like you can just set preference code:
astral fucked around with this message at 02:25 on May 18, 2015 |
# ? May 18, 2015 02:23 |
|
Who likes beta testing? The first pre-release version of restartless SALR is here! (note: you will not auto-update to this version, but this version will auto-update to the next release version) pre-release notes posted:
Please report any issues! If you encounter some kind of extension- or browser-breaking problem and you want to switch back to the last release version, that's here. Known issues:
astral fucked around with this message at 00:40 on May 20, 2015 |
# ? May 18, 2015 06:31 |
|
I'll try it out, my quick reply/quote buttons have been broken since the latest firefox (beta) update so I've got nothing to lose . e; aww yeah new salr looks good. Quick reply/quote/edit still broken though. e2; nevermind it was a greasemonkey extension causing the issue. Dodoman fucked around with this message at 06:53 on May 18, 2015 |
# ? May 18, 2015 06:47 |
|
Woohoo tab preferences!
|
# ? May 18, 2015 12:48 |
|
The second pre-release version of restartless SALR is here! (note: you will not auto-update to this version, but this version will auto-update to the next release version) new since pre-release 1 posted:
pre-release 1 notes posted:
Please report any issues! If you encounter some kind of extension- or browser-breaking problem and you want to switch back to the last release version, that's here. Known issues:
astral fucked around with this message at 06:32 on May 21, 2015 |
# ? May 20, 2015 07:33 |
|
Third pre-release version of restartless SALR (note: you will not auto-update to this version, but this version will auto-update to the next release version) new since pre-release 2 posted:
pre-release 2 notes posted:
pre-release 1 notes posted:
Please report any issues! If you encounter some kind of extension- or browser-breaking problem and you want to switch back to the last release version, that's here.
|
# ? May 21, 2015 11:45 |
|
Not sure what's causing this onecode:
|
# ? May 22, 2015 20:09 |
|
Fourth pre-release version of restartless SALR (note: you will not auto-update to this version, but this version will auto-update to the next release version) new since pre-release 3 posted:
pre-release 3 notes posted:
pre-release 2 notes posted:
pre-release 1 notes posted:
Please report any issues! If you encounter some kind of extension- or browser-breaking problem and you want to switch back to the last release version, that's here. astral fucked around with this message at 21:20 on May 22, 2015 |
# ? May 22, 2015 21:18 |
|
After installing some random unrelated addons, suddenly my Firefox options are in a tab. Didn't explicitly ask for that, but ok, I don't mind either way. What I thought was that SALR would now als show its preferences in a tab, but it doesn't. It's just the same panel as before. I don't really give a poo poo, but since it's a new feature, I thought you'd like to know. If there's any information you need to help troubleshoot this, let me know. I also might just be completely misunderstanding the concept. Currently running the version posted above.
|
# ? May 22, 2015 22:06 |
|
Flipperwaldt posted:After installing some random unrelated addons, suddenly my Firefox options are in a tab. Didn't explicitly ask for that, but ok, I don't mind either way. What I thought was that SALR would now als show its preferences in a tab, but it doesn't. It's just the same panel as before. How are you opening SALR's preferences, through Firefox's add-ons page or the sa menu/toolbar menu/inline SALR Config link? If it's the add-ons page, that one's not hooked up yet. If it's anywhere else, please go to about :config and post the value of "browser.preferences.inContent" edit: Also, if you upgraded Firefox to version 38, that's what caused your Firefox options to start opening in a tab. astral fucked around with this message at 22:44 on May 22, 2015 |
# ? May 22, 2015 22:37 |
|
Speaking of that, when I open the preferences using the link in the forum header, the General tab is blank. I have to click on another tab then back for any of the options to show. It works fine opening from the toolbar menu.
|
# ? May 22, 2015 22:43 |
|
Kassad posted:Speaking of that, when I open the preferences using the link in the forum header, the General tab is blank. I have to click on another tab then back for any of the options to show. It works fine opening from the toolbar menu. Good catch; I have that link disabled so I hadn't seen that. e: fixed for the next pre-release version astral fucked around with this message at 23:01 on May 22, 2015 |
# ? May 22, 2015 22:46 |
|
astral posted:How are you opening SALR's preferences, through Firefox's add-ons page or the sa menu/toolbar menu/inline SALR Config link? If it's the add-ons page, that one's not hooked up yet. If it's anywhere else, please go to about :config and post the value of "browser.preferences.inContent" Could have sworn I had a couple of days with 38 before the switch happened, but I'm probably mistaken. I guess it's all as it is supposed to be then.
|
# ? May 22, 2015 22:52 |
|
Dodoman posted:Not sure what's causing this one This got fixed in the latest pre-release version
|
# ? May 23, 2015 07:25 |
|
Fifth pre-release version of restartless SALR is a second build for today mainly to fix options-related woes and get some extra testing in for the improved search box. (note: you will not auto-update to this version, but this version will auto-update to the next release version) new since pre-release 4 posted:
See previous posts for older notes. Please report any issues! If you encounter some kind of extension- or browser-breaking problem and you want to switch back to the last release version, that's here.
|
# ? May 23, 2015 08:37 |
|
|
# ? Apr 25, 2024 00:41 |
|
Can't get the color picker to actually save a color. Clicking ok seems to do pretty much the same thing as cancelling (from a user perspective). In both user colors and thread/post colors. Even clicking the reset button for the thread/post colors doesn't do anything but warn me it can't be undone. After that colors stay the same old custom colors I had.
|
# ? May 23, 2015 16:20 |