awful programming: feature flags and suffering

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > YOSPOS > awful programming: feature flags and suffering

«‹›1119 »

distortion park: Apr 25, 2011

the superior vcs (hg) solves the rewrite issue but marking commits as unpublished or published. As long as you don't push your history you can rewrite it but after that it's much more restrictive.

(there's also a 3rd "don't push this commit" state to make it easy to manage wip stuff)

# ? Sep 7, 2018 11:27

Adbot: ADBOT LOVES YOU

# ? May 23, 2024 05:08

TheFluff: Dec 13, 2006; FRIENDS, LISTEN TO ME
I AM A SEAGULL
OF WEALTH AND TASTE

Luigi Thirty posted:

you write one template function in C++ and suddenly your whole world is internal compiler errors when it breaks

tiny brain: uses preprocessor macros as poor man's generics
ascended brain: uses C++ templates for generics
galaxy brain:

code:

#define BUILDER_MEMBER(type, name) \
  template <class T> \
  auto set_##name(T &&val) -> decltype(*this) { name = std::forward<T>(val); return *this; } \
  type name;

# ? Sep 7, 2018 14:42

Luigi Thirty: Apr 30, 2006; Emergency confection port.

n-nooooooo

I'm trying to do horrible things in C++

I have two classes, Texture and Model3D. they inherit from an abstract base class/interface IHasName which defines a virtual IsNamed search predicate for lookups which the classes implement.

I keep track of textures and models in two vector<IHasName *> containers with a template function FindInVectorByName that converts the pointers to the correct type before returning the search result, i.e. you call FindInVectorByName<Texture>(vector_of_textures, "poop") and it returns a Texture *

I know you can't directly cast IHasName * to Model3D * or Texture * but I'd like to enforce type-safety on my vectors so I don't end up with textures in my model vector if I gently caress up somewhere. this seems like a bad way of doing things.

I need a C++ scholar here to tell me how to do this correctly because I think this is a terrible programming and I'm ready to move to Belize

Luigi Thirty fucked around with this message at 14:52 on Sep 7, 2018

# ? Sep 7, 2018 14:49

Finster Dexter: Oct 20, 2014; Beyond is Finster's mad vision of Earth transformed.

cjs: well, I'm hosed.

In Go, I'm consuming JSON data off a websocket. This data has a price field that is a decimal with fractions of pennies, so could be -0.000345 or whatever. Go does not have a decimal type in stdlib. So, now I have to basically roll-my-own JSON parser so I can get this loving value into my (third-party) decimal type field without having to drop it into a float and lose precision.

Now, you might be wondering if there is some means to override parts of the JSON parser to handle this particular field with special fixed-precision kidgloves, and there is, but it won't let me parse a number field as a string. It returns an error in that case. Thus, I'm back to re-implementing JSON parsing.

Calgon, take me away...

# ? Sep 7, 2018 15:23

Lime: Jul 20, 2004

if you want a vector that only has Textures in it then make it a vector<Texture*>?? FindInVectorByName already has some template parameter T so just make its first function parameter a vector<T*> instead of a vector<IHasName*>

if you really insist on not knowing what's in your vector then you're going to have to use dynamic_cast and just eat the associated cost

# ? Sep 7, 2018 15:25

Zlodo: Nov 25, 2006

Luigi Thirty posted:

n-nooooooo

I'm trying to do horrible things in C++

I have two classes, Texture and Model3D. they inherit from an abstract base class/interface IHasName which defines a virtual IsNamed search predicate for lookups which the classes implement.

I keep track of textures and models in two vector<IHasName *> containers with a template function FindInVectorByName that converts the pointers to the correct type before returning the search result, i.e. you call FindInVectorByName<Texture>(vector_of_textures, "poop") and it returns a Texture *

I know you can't directly cast IHasName * to Model3D * or Texture * but I'd like to enforce type-safety on my vectors so I don't end up with textures in my model vector if I gently caress up somewhere. this seems like a bad way of doing things.

I need a C++ scholar here to tell me how to do this correctly because I think this is a terrible programming and I'm ready to move to Belize

You don't need the interface to do this because FindInVectorByName already knows the type.
This could look like this:

class Texture
{
// your IsNamed predicate here, not virtual
};

class Model3d
{
// your IsNamed predicate here, also not virtual
};

template< typename T >
const T* FindInVectorByName< const vector< T >& myVec, const char* myName )
{
// iterate through myvec, call IsNamed to find if it's what you're looking for
}

Zlodo fucked around with this message at 15:32 on Sep 7, 2018

# ? Sep 7, 2018 15:29

carry on then: Jul 10, 2010; by VideoGames
(and can't post for 10 years!)

Zlodo posted:

You don't need the interface to do this because FindInVectorByName alrady knows the type.
Here's a possible solution:

class Texture
{

}

please don't post java

# ? Sep 7, 2018 15:30

Luigi Thirty: Apr 30, 2006; Emergency confection port.

Lime posted:

if you want a vector that only has Textures in it then make it a vector<Texture*>?? FindInVectorByName already has some template parameter T so just make its first function parameter a vector<T*> instead of a vector<IHasName*>

if you really insist on not knowing what's in your vector then you're going to have to use dynamic_cast and just eat the associated cost

knowing what's in my vectors would be nice

Zlodo posted:

You don't need the interface to do this because FindInVectorByName already knows the type.
This could look like this:

class Texture
{
// your IsNamed predicate here, not virtual
};

class Model3d
{
// your IsNamed predicate here, also not virtual
};

template< typename T >
const T* FindInVectorByName< const vector< T >& myVec, const char* myName )
{
// iterate through myvec, call IsNamed to find if it's what you're looking for
}

doh ok I don't need the interface at all thanks

# ? Sep 7, 2018 15:40

Shaggar: Apr 26, 2006

Finster Dexter posted:

Go does not have a decimal type in stdlib.

what?

# ? Sep 7, 2018 16:10

anthonypants: May 6, 2007; by Nyc_Tattoo; Dinosaur Gum

Shaggar posted:

what?

https://github.com/golang/go/issues/12127

# ? Sep 7, 2018 16:14

tef: May 30, 2004; -> some l-system crap ->

brap posted:

can someone explain to me how a commit gets "lost" in git because that has never happened to me

i have had to pull poo poo out of the reflog before but that does not mean anything was lost.

work in detached head mode or break a rebase

# ? Sep 7, 2018 16:18

tef: May 30, 2004; -> some l-system crap ->

people who're talking about what people *should* and *shouldn't* do with a vcs is lovely please never design anything

'why would you need to do this thing, it works on my machine'

that's great shut up

like you need some history rewriting ability because people commit poo poo that *should* not have been committed and has to be purged, you loving muppets

# ? Sep 7, 2018 16:20

Fiedler: Jun 29, 2002; I, for one, welcome our new mouse overlords.

Finster Dexter posted:

In Go, I'm consuming JSON data off a websocket.

why are you wasting time with this when you should be converting to .Net?

# ? Sep 7, 2018 16:21

tef: May 30, 2004; -> some l-system crap ->

then the complete ignorance of 'well dont commit those wip commits' i am sorry i'm using a version control system

like at the point where you'e not doing an OT model and merging keystrokes you're already lying about the history

what gives

# ? Sep 7, 2018 16:23

DONT THREAD ON ME: Oct 1, 2002; by Nyc_Tattoo; Floss Finder

or if you push a branch and it never gets merged you're not allowed to delete it ever because that's rewriting history.

# ? Sep 7, 2018 16:27

DONT THREAD ON ME: Oct 1, 2002; by Nyc_Tattoo; Floss Finder

anyhow i bought a game engine architecture book and a linear algebra book and i'm enjoying both. i think i'm going to use opengl to draw graphs of the linear algebra stuff i'm learning.

# ? Sep 7, 2018 16:27

CPColin: Sep 9, 2003; Big ol' smile.

Back at a previous job, I had a real conflict of interest with myself between people who would be out sick on the last day of a sprint and hadn't pushed their latest changes vs. people who endlessly did "WIP" and "fix" commits and made blames completely worthless. And stupid BitBucket didn't have a "squash and merge" button on PR's, like GitHub does.

Really, though, a lot of the problem was the dogma that everything always had to be released at the end of the sprint and nobody ever just bumped a ticket in the event of an illness or whatever. Still, it just made PR's loving complicated.

# ? Sep 7, 2018 16:29

Jabor: Jul 16, 2010; #1 Loser at SpaceChem

rewriting history on master should absolutely not be part of your normal workflow. if someone pushes some sensitive information that shouldn't be there, there should be a way to remove it, but it should involve contacting someone who administers the server, and also writing a retrospective on how that sensitive information got there to begin with and what process changes can be made to prevent a similar fuckup from happening in the future.

do whatever you like on your local vcs, though. that one's yours. the thing everyone else cares about is what commits you're pushing to master, which should absolutely not be your half-broken wip commits

# ? Sep 7, 2018 16:33

MononcQc: May 29, 2007

I like mercurial's approach of tracking what is a public and a private repository (or branches) and only allowing rewrite on stuff that is not marked as public (in order to avoid breaking the workflow of others)

# ? Sep 7, 2018 16:57

DONT THREAD ON ME: Oct 1, 2002; by Nyc_Tattoo; Floss Finder

MononcQc posted:

I like mercurial's approach of tracking what is a public and a private repository (or branches) and only allowing rewrite on stuff that is not marked as public (in order to avoid breaking the workflow of others)

yeah that sounds real good, would like that in git.

# ? Sep 7, 2018 17:00

raminasi: Jan 25, 2005; a last drink with no ice

but don�t you want to be able to see my ~~workflow~~?

# ? Sep 7, 2018 17:01

prisoner of waffles: May 8, 2007; Ah! well a-day! what evil looks
Had I from old and young!
Instead of the cross, the fishmech
About my neck was hung.

DONT THREAD ON ME posted:

yeah that sounds real good, would like that in git.

depending on your remote backend, you can disable force pushes for specific branches

# ? Sep 7, 2018 17:13

Powerful Two-Hander: Mar 10, 2004; Mods please change my name to "Tooter Skeleton" TIA.

hi its me, I'm the guy making GBS threads up the history with all his individual commits because idgaf

i am a trash man
squash em all 2018 etc etc.

# ? Sep 7, 2018 17:50

tef: May 30, 2004; -> some l-system crap ->

i found out git headers are a great way to smuggle information about because they're pretty much unseen in all of the tooling

# ? Sep 7, 2018 17:52

Shaggar: Apr 26, 2006

anthonypants posted:

https://github.com/golang/go/issues/12127

incredible. why does anyone use go?

# ? Sep 7, 2018 17:54

Toady: Jan 12, 2009

MononcQc posted:

I like mercurial's approach of tracking what is a public and a private repository (or branches) and only allowing rewrite on stuff that is not marked as public (in order to avoid breaking the workflow of others)

mercurial was the first distributed version control i used, and it was pleasant, and i was bummed when git exploded in popularity. i've learned the core commands i need to get work done with git, but once in a while, i have to deal with its complexity, and it's such a time-waster trying to figure it out

# ? Sep 7, 2018 18:12

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

for me most of gits shittiness comes from the fact that I have two dev machines since I work from home regularly. long lived branches can be ugly to manage if I work on them on both machines a few times.

# ? Sep 7, 2018 18:17

carry on then: Jul 10, 2010; by VideoGames
(and can't post for 10 years!)

jit bull transpile posted:

for me most of gits shittiness comes from the fact that I have two dev machines since I work from home regularly. long lived branches can be ugly to manage if I work on them on both machines a few times.

i've gotten to the point where i push just about everything to my personal fork of the relevant repo, so syncing to another system is just a git pull

# ? Sep 7, 2018 18:18

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

carry on then posted:

i've gotten to the point where i push just about everything to my personal fork of the relevant repo, so syncing to another system is just a git pull

same, but sometimes one of my machines will just start refusing to recognize there's new commits to pull and I have to do voodoo to get it working again.

# ? Sep 7, 2018 18:25

Luigi Thirty: Apr 30, 2006; Emergency confection port.

jit bull transpile posted:

same, but sometimes one of my machines will just start refusing to recognize there's new commits to pull and I have to do voodoo to get it working again.

try installing a glide wrapper

# ? Sep 7, 2018 19:33

pseudorandom name: May 6, 2007

Shaggar posted:

incredible. why does anyone use go?

C++ doesn't have a decimal type either

# ? Sep 7, 2018 19:48

Progressive JPEG: Feb 19, 2003

Finster Dexter posted:

cjs: well, I'm hosed.

In Go, I'm consuming JSON data off a websocket. This data has a price field that is a decimal with fractions of pennies, so could be -0.000345 or whatever. Go does not have a decimal type in stdlib. So, now I have to basically roll-my-own JSON parser so I can get this loving value into my (third-party) decimal type field without having to drop it into a float and lose precision.

Now, you might be wondering if there is some means to override parts of the JSON parser to handle this particular field with special fixed-precision kidgloves, and there is, but it won't let me parse a number field as a string. It returns an error in that case. Thus, I'm back to re-implementing JSON parsing.

Calgon, take me away...

# ? Sep 7, 2018 20:50

Spime Wrangler: Feb 23, 2003; Because we can.

Luigi Thirty posted:

try installing a glide wrapper

# ? Sep 7, 2018 21:04

The MUMPSorceress: Jan 6, 2012; ^SHTPSTS; Gary’s Answer

Luigi Thirty posted:

try installing a glide wrapper

I'm not loving the computer..
why would I need a lubricated condom?

# ? Sep 7, 2018 21:22

gonadic io: Feb 16, 2011; >>=

Luigi Thirty posted:

try installing a glide wrapper

I didn't realise we were in the velocity thread

# ? Sep 7, 2018 21:25

suffix: Jul 27, 2013; Wheeee!

eschaton posted:

there�s an informative comparison of Veracity with other distributed version control systems on its site

love the key feature of skein

# ? Sep 7, 2018 22:08

Slurps Mad Rips: Jan 25, 2009; Bwaltow!

Luigi Thirty posted:

knowing what's in my vectors would be nice

doh ok I don't need the interface at all thanks

also, for future reference, when working with base classes, you can use dynamic_cast and the if assign approach to enter specific type blocks (as long as you know all the types or don't care about anything but one or two)

Something like this if you're stuck with msvc 6

C++ code:

struct Base { virtual ~Base() = default; };
struct Derived1 : Base { };
struct Derived2 : Base { };

void function (Base* ptr) {
  if (Derived1* d = dynamic_cast<Derived1*>(ptr)) {
    // do a thing here
  } else if (Derived2* d = dynamic_cast<Derived*>(ptr)) {
    // do a different thing here
  } else {
    // this is your fallback state in case additional classes are added in the future.
  }
}

# ? Sep 7, 2018 22:15

champagne posting: Apr 5, 2006; YOU ARE A BRAIN
IN A BUNKER

pseudorandom name posted:

C++ doesn't have a decimal type either

SQL does

and the guy who set up the SQL server at work used the type to produce large zero precision numbers, i.e. numbers with up to 18 decimals, with none after the decimal place.

# ? Sep 7, 2018 22:15

Luigi Thirty: Apr 30, 2006; Emergency confection port.

apparently I compiled stlport without RTTI lol, rip _cast functions

I�ll rebuild it with RTTI and see if it works

# ? Sep 7, 2018 22:20

Adbot: ADBOT LOVES YOU

# ? May 23, 2024 05:08

suffix: Jul 27, 2013; Wheeee!

redleader posted:

i've heard people say poo poo like "history should be immutable because if i'm chasing a bug i need to ~understand the thought process~ that the original developer went through. if they rewrite history, i won't be able to read the total history to ~understand~ how the bug was introduced". you haven't ever done or needed to do this, gently caress you

i have definitely been annoyed before irl at giant squashed "add feature x" commits that touch 300 files, because i was trying to figure out why line n changed, and it was very likely a "oh bar needs to be baz now because the frobnicator failed when i ran the tests" commit originally
remove the wip garbage commits if you must but ffs merge don't squash and rebase

# ? Sep 7, 2018 22:22

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > YOSPOS > awful programming: feature flags and suffering

«‹›1119 »