SALR Redux - More browsers, better taste! (chrome users: uninstall the button ext!)

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > SALR Redux - More browsers, better taste! (chrome users: uninstall the button ext!)

«‹›21 »

astral: Apr 26, 2004

Endymion FRS MK1 posted:

Perfect, thank you! Question though, why the different settings?

The Firefox version of SALR Redux tries to keep the color settings of Legacy SALR.

# ? Mar 14, 2019 05:35

Adbot: ADBOT LOVES YOU

# ? Apr 19, 2024 19:04

Nalin: Sep 29, 2007; Hair Elf

You know that "Convert webm/gfycat links to inline video" option? Can it be expanded to include imgur .gifv links? I've seen people somehow embed .gifv videos inside <img> tags on the forum and my Firefox doesn't show them. Is that happening for anyone else with Firefox?

# ? Mar 19, 2019 17:09

astral: Apr 26, 2004

Nalin posted:

You know that "Convert webm/gfycat links to inline video" option? Can it be expanded to include imgur .gifv links? I've seen people somehow embed .gifv videos inside <img> tags on the forum and my Firefox doesn't show them. Is that happening for anyone else with Firefox?

People putting gifv links inside img tags is a mistake that doesn't work for anyone; it's not something SALR should encourage.

The forums javascript embeds those if they're within url tags (whether you add the url tags yourself or let the forums do so automatically by just pasting the link).

# ? Mar 19, 2019 18:02

Nalin: Sep 29, 2007; Hair Elf

I probably should have checked, but yeah, no browser will show it if it is inside <img> tags. Weird since I see it every now and then. I figured something like Chrome was just allowing it for whatever reason.

# ? Mar 19, 2019 22:17

Flipperwaldt: Nov 11, 2011; Won't somebody think of the starving hamsters in China?

Nalin posted:

I probably should have checked, but yeah, no browser will show it if it is inside <img> tags. Weird since I see it every now and then. I figured something like Chrome was just allowing it for whatever reason.

The android app allows it. Just like it plain shows http linked images that work nowhere else.

Also when you do gifvs the proper way, they don't show up in post preview, so maybe you've got people hypercorrecting to img tags because they think they did it wrong when they didn't.

# ? Mar 19, 2019 22:43

gary oldmans diary: Sep 26, 2005

I broke the Quick-Reply box again. Is it the api.imgur.com dialog box preventing it from working? I've tried Allow and I've tried Deny.

# ? Mar 22, 2019 12:31

astral: Apr 26, 2004

gary oldmans diary posted:

I broke the Quick-Reply box again. Is it the api.imgur.com dialog box preventing it from working? I've tried Allow and I've tried Deny.

The permission shouldn't be a problem. Are you seeing the dialog box more than once? I don't think I've seen it since initially allowing it.

Quick reply normally breaks if you hit the forwards or backwards button before or after clicking it. I imagine the cache and the content script don't play well together.

# ? Mar 22, 2019 18:40

gary oldmans diary: Sep 26, 2005

Nah, it breaks when I try to change an SALR option. After that, I see the api dialogue if I try to uncheck the quick-reply box so I can check it again in hopes that that will get things back.

# ? Mar 23, 2019 06:54

astral: Apr 26, 2004

gary oldmans diary posted:

Nah, it breaks when I try to change an SALR option. After that, I see the api dialogue if I try to uncheck the quick-reply box so I can check it again in hopes that that will get things back.

Is this something you can reliably reproduce? If so, please walk us through the steps necessary to do so. Thanks!

# ? Mar 23, 2019 07:06

gary oldmans diary: Sep 26, 2005

I started disabling features (got things working again) and I think I've got it narrowed down.

Header/Footer Link Display Options
� Display Navigation menu links (checked)
� � � Forum Rules (unchecked)

seems to break SALR in various ways. Just keeping it checked for now.

These were the other options in that category I had selected other than Forum Rules in case there's any effect from combining:

gary oldmans diary fucked around with this message at 07:35 on Mar 23, 2019

# ? Mar 23, 2019 07:30

astral: Apr 26, 2004

gary oldmans diary posted:

I started disabling features (got things working again) and I think I've got it narrowed down.

Header/Footer Link Display Options
� Display Navigation menu links (checked)
� � � Forum Rules (unchecked)

seems to break SALR in various ways. Just keeping it checked for now.

Good find! I can see why - looks like it's hard-coded to check for an http:// link for the forum rules and the forums have changed it to an https:// link.

edit: fixed for the next release, which'll happen after I finish making the post history tracking migration stuff for Chrome

astral fucked around with this message at 07:45 on Mar 23, 2019

# ? Mar 23, 2019 07:35

Stare-Out: Mar 11, 2010

Firefox SALR is terribly broken for me right now.

I tried various fixes posted in this thread but since reinstalling Firefox I've lost the links to open unread threads in both bookmarks and forums and quick reply doesn't work anymore. Sorry if this is already known but I figured I'd voice my issues just in case.

# ? Apr 5, 2019 22:10

astral: Apr 26, 2004

Stare-Out posted:

Firefox SALR is terribly broken for me right now. I tried various fixes posted in this thread but since reinstalling Firefox I've lost the links to open unread threads in both bookmarks and forums and quick reply doesn't work anymore. Sorry if this is already known but I figured I'd voice my issues just in case.

Did you already make sure it's not trying to hide the forum rules link (discussed in the last two posts if you need a pic of what the setting looks like)?

# ? Apr 5, 2019 22:14

Stare-Out: Mar 11, 2010

astral posted:

Did you already make sure it's not trying to hide the forum rules link (discussed in the last two posts if you need a pic of what the setting looks like)?

Yeah, I tried it both ways and other variants too just in case, along with the earlier fix (that did work for me at the time) of highlighting thread counts to get the links to show up but it didn't work.

E: And I unchecked/checked both of the "Display "Open all unread messages" link" too.

E2: Is there a way to clear all settings and do a clean install of SALR that I'm missing? In case signing into the new Firefox maybe brought all my old settings back and that screwed something up.

Stare-Out fucked around with this message at 22:22 on Apr 5, 2019

# ? Apr 5, 2019 22:17

astral: Apr 26, 2004

Stare-Out posted:

Yeah, I tried it both ways and other variants too just in case, along with the earlier fix (that did work for me at the time) of highlighting thread counts to get the links to show up but it didn't work.

E: And I unchecked/checked both of the "Display "Open all unread messages" link" too.

E2: Is there a way to clear all settings and do a clean install of SALR that I'm missing? In case signing into the new Firefox maybe brought all my old settings back and that screwed something up.

Only cloud settings right now are for notes if I remember correctly, so that shouldn't be a/the problem. You might be able to force the default settings by uninstalling the addon and then reinstalling it. Not 100% on how it handles extension localStorage at the moment. Will be simpler once it is migrated to storage.local.

Before you do that, can you please post or PM your config settings from the Miscellaneous preferences?

Also before doing that, can you find an affected page, open the console tab in the f12 panel (or ctrl+shift+k), hit the little trash can button, refresh the broken page, and copy+paste whatever output shows up into a PM or post?

A screenshot of how it looks broken would be great too.

These things should make it easy to track down whatever specific thing is causing this. Thanks for reporting it!

astral fucked around with this message at 02:35 on Apr 6, 2019

# ? Apr 6, 2019 02:31

Stare-Out: Mar 11, 2010

These are the current SALR settings:

code:

{"topUserCP":"true","dontReplaceLinkSpoiler":"false","quickReplyBookmark":"false","quickReplyParseUrls":"true","hideUserGrenade":"false","enableUserNotesSync":"true","highlightOP":"false","dontReplaceLinkImage":"false","dontReplaceVineSpoiler":"false","showLastThreePagesThread":"true","imageLinkHoverShowURL":"true","bottomNavBar":"false","replaceImagesLink":"false","highlightModAdminUsername":"false","ignoreBookmarkStarRed":"false","topLogout":"false","enableUserNotes":"true","topPurchaseAva":"true","topPurchaseArchives":"true","quickReplyFormat":"true","enableQuickReply":"true","setImageTooltipHideSourceUrl":"true","darkRead":"#bbccdd","highlightOwnUsername":"true","preventAdjust":"true","imageLinkHoverNWS":"true","retinaImages":"false","fixUserCPFont":"true","imageLinkHover":"false","topSALink":"true","highlightSelf":"false","topPurchaseUsername":"true","boxQuotes":"false","displayConfigureSalr":"true","expandBreadcrumbs":"false","collapseTldrQuotes":"false","showLastThreePages":"false","displayNewPostsFirstUCP":"true","openAllForumUnreadLink":"true","MouseActiveContext":"false","qneProtection":"true","showNavigation":"true","topNavBar":"true","topPrivMsgs":"true","dontReplaceLinkRead":"false","inlineVideo":"false","topSAForums":"true","hidePostButtonInThread":"false","displayNewPostsFirst":"true","fixImgurLinks":"false","inlineWemAutoplay":"true","showLastThreePagesForum":"true","topSaclopedia":"true","topPurchaseSticky":"false","lightRead":"#ddeeff","topPurchaseEmoticon":"false","highlightFriends":"false","openAllUnreadLink":"true","enableSinglePost":"true","adjustAfterLoad":"true","topGloryhole":"true","ignoreBookmarkStarYellow":"false","inlineWebm":"false","hideGarbageDick":"true","inlineVine":"false","topLepersColony":"true","displayNewPostsFirstForum":"true","highlightAdminColor":"#ff7256","topForumRules":"false","displayCustomButtons":"false","enableThreadNotes":"false","ignoreForumStarGold":"false","highlightFriendsColor":"#f2babb","dontReplaceVineNWS":"false","salrInitialized":"true","highlightOPColor":"#fff2aa","ignoreForumStarYellow":"false","topSupport":"false","enableMouseMenu":"false","highlightModeratorColor":"#b4eeb4","darkNewReplies":"#bae8ba","enableSAARSLink":"true","quickReplyDisableSmilies":"false","userNotesLocal":"null","enableMouseGestures":"false","restrictImagePxH":"800","replaceImagesReadOnly":"false","userQuote":"#a2cd5a","usernameHighlight":"#9933ff","topPurchaseGiftCert":"false","salrLogoHide":"true","enableToggleUserAvatars":"true","showPurchases":"true","removeOwnReport":"true","setImageTooltipHideExtension":"true","setImageTooltipSkipEmoticons":"true","topSearch":"true","username":"Stare-Out","restrictImageSize":"false","dontReplaceLinkNWS":"false","saveUserNotes":"true","enableMouseUpUCP":"false","showUserAvatarImage":"true","whoPostedHide":"false","ignoreBookmarkStarGold":"false","highlightSelfColor":"#f2babb","inlinePostCounts":"false","topPurchaseBannerAd":"false","highlightModAdmin":"false","showLastThreePagesUCP":"true","highlightOwnQuotes":"false","ignoreForumStarNone":"false","usernameCase":"false","dontReplaceWebmNWS":"false","topPurchaseAcc":"false","showEditBookmarks":"false","fixCancer":"true","ignoreForumStarRed":"false","searchThreadHide":"false","replaceImagesWithLinks":"false","quickReplyYoutube":"true","displayPageNavigator":"false","showUserAvatar":"true","setImageTooltip":"false","displayMods":"false","enableKeyboardShortcuts":"false","replaceLinksWithImages":"false","quickReplyEmotes":"true","topPurchaseNoAds":"false","quickReplyLivePreview":"false","youtubeHighlight":"#ffcccc","imageLinkHoverShowFilename":"false","threadCaching":"false","loadNewWithLastPost":"true","dontReplaceWebmSpoiler":"false","imageLinkHoverSpoiler":"true","hideAdvertisements":"true","highlightThread":"true","quickReplySignature":"false","setImageTooltipBlankOnly":"true","lightNewReplies":"#afdbaf","topPurchasePlat":"false","postsPerPage":"default","imageLinkHoverDelay":"0","restrictImagePxW":"800"}

As for the console thing, this is what I get on every page:

code:

Loading failed for the <script> with source �[url]https://www.googletagmanager.com/gtag/js?id=UA-33089744-1�.[/url] forumdisplay.php:1:1
JQMIGRATE: Migrate is installed, version 1.4.0 jquery-migrate.min.js:2:542
ReferenceError: twemoji is not defined[Learn More] forums.combined.js:3:1
JQMIGRATE: Migrate is installed, version 3.0.1 jquery-migrate-3.0.1.min.js:33:9
Loading failed for the <script> with source �[url]https://cdn.taboola.com/libtrc/somethingawful1/loader.js�.[/url] forumdisplay.php:1:1
Loading failed for the <script> with source �[url]https://d31qbv1cthcecs.cloudfront.net/atrk.js�.[/url] forumdisplay.php:1:1
Loading failed for the <script> with source �[url]https://edge.quantserve.com/quant.js?_=1554545360847�.[/url] forumdisplay.php:1:1

# ? Apr 6, 2019 11:15

ChickenOfTomorrow: Nov 11, 2012; god damn it, you've got to be kind

Feature request: make the "edit note" button and usernotes display available on the userinfo and newreply pages as well as showthread?

# ? Apr 6, 2019 18:27

iospace: Jan 19, 2038

Does anyone remember the original hex color codes for the UserCP view? Thanks.

# ? May 22, 2019 23:54

astral: Apr 26, 2004

SALR was disabled in the addons.mozilla.org gallery because it uses gfycat's embedding; existing users can continue using it though (according to the e-mail).

# ? Jun 23, 2019 23:04

Nalin: Sep 29, 2007; Hair Elf

Why would that get it kicked off of AMO?

# ? Jun 23, 2019 23:39

astral: Apr 26, 2004

Nalin posted:

Why would that get it kicked off of AMO?

Redux uses 'remote JS' (embeds a gfycat js file) to accomplish the embed and I guess a.m.o is cracking down on it because it could potentially be something malicious, or be changed to such by gfycat. Never mind that it only runs for pages on SA to begin with, only for links to the 'malicious' site, and it runs in the context of the page and not the extension. One valid complaint they didn't make is that it appears to add said JS fetched over an http:// link which could be tampered with in transit.

I think the forums do that gfycat inlining by default anyway now so that part of it, if not the entire webm inlining from SALR could probably just be purged as redundant. Will check into it when I have time.

# ? Jun 24, 2019 00:04

immortalyawn: May 28, 2013; by LITERALLY AN ADMIN

Is there a Stylus (or other) Dark Theme that works good with SALR?

I like the highlighting of posts/users options, but themes override these setting.

ALSO:

What setting is causing this white line to appear at the bottom of every post?

Appears on first page load, and USUALLY goes away after refreshing the page.

immortalyawn fucked around with this message at 07:14 on Jun 26, 2019

# ? Jun 25, 2019 07:46

Sereri: Sep 30, 2008; awwwrigami

Lowtax is bad at css, but also salr adds the [1] button which causes the left container there to overflow onto a second line.
The right container stays the previous size which exposes the white background of the page.

# ? Jun 26, 2019 09:24

Nalin: Sep 29, 2007; Hair Elf

Sereri posted:

Lowtax is bad at css, but also salr adds the [1] button which causes the left container there to overflow onto a second line.
The right container stays the previous size which exposes the white background of the page.

SALR adds a white-space: nowrap CSS property that prevents that, though. Did something change? Maybe he has an older version of SALR or something else messing with the CSS?

# ? Jun 26, 2019 17:17

immortalyawn: May 28, 2013; by LITERALLY AN ADMIN

Sereri posted:

Lowtax is bad at css, but also salr adds the [1] button which causes the left container there to overflow onto a second line.
The right container stays the previous size which exposes the white background of the page.

Yep.

This is the culprit.

# ? Jun 28, 2019 08:10

Flipperwaldt: Nov 11, 2011; Won't somebody think of the starving hamsters in China?

You can set the time format in the forums settings to 24h, I think. AM or PM after the post date takes up as much space as the added button would.

# ? Jun 28, 2019 09:59

novamute: Jul 5, 2006; o o o

astral posted:

SALR was disabled in the addons.mozilla.org gallery because it uses gfycat's embedding; existing users can continue using it though (according to the e-mail).

drat just a few days before I switched over to FF. Missing the keyboard shortcuts already.

# ? Jun 28, 2019 18:55

immortalyawn: May 28, 2013; by LITERALLY AN ADMIN

User notes and hide peoples avatars is not in the Chrome version?

The user notes options are there but doesn't seem to work.

immortalyawn fucked around with this message at 09:09 on Jul 17, 2019

# ? Jul 17, 2019 04:16

101: Oct 15, 2012; Vault Dweller

Would it be possible to add a setting for which keyboard shortcuts you want?

I only want to use 'O' to anchor posts when Twitter poo poo throws it off but I don't really want the rest active.

# ? Jul 24, 2019 01:12

Solomon Gumball: Jul 24, 2019

Can someone attach the xpi here for the latest versions since its off the add-on page.

# ? Jul 27, 2019 19:13

bunky: Aug 29, 2004

Solomon Gumball posted:

Can someone attach the xpi here for the latest versions since its off the add-on page.

Yo, same here. I just reinstalled Windows and forgot how useful salr is until I lost it.

# ? Aug 24, 2019 13:09

astral: Apr 26, 2004

https://bintray.com/salr/salr-firefox/download_file?file_path=something_awful_last_read_redux-2.1.8.13a12-an%2Bfx.xpi is the last signed version; not 100% if they can prevent it from installing or not since it's disabled on a.m.o. but we'll see!

# ? Aug 24, 2019 19:47

bunky: Aug 29, 2004

astral posted:

https://bintray.com/salr/salr-firefox/download_file?file_path=something_awful_last_read_redux-2.1.8.13a12-an%2Bfx.xpi is the last signed version; not 100% if they can prevent it from installing or not since it's disabled on a.m.o. but we'll see!

Worked for me. I just dragged and dropped it into an open firefox window. Thanks!

# ? Aug 24, 2019 22:17

novamute: Jul 5, 2006; o o o

astral posted:

https://bintray.com/salr/salr-firefox/download_file?file_path=something_awful_last_read_redux-2.1.8.13a12-an%2Bfx.xpi is the last signed version; not 100% if they can prevent it from installing or not since it's disabled on a.m.o. but we'll see!

Partially working for me. Thread Highlighting and Header/Footer options are working properly but Forums Display and Control options don't seem to have any effect.

# ? Aug 26, 2019 18:58

astral: Apr 26, 2004

novamute posted:

Partially working for me. Thread Highlighting and Header/Footer options are working properly but Forums Display and Control options don't seem to have any effect.

I wouldn't be surprised if some specific option that applies to only those pages were breaking it. Feel free to PM me your current options (misc commands -> copy json settings string) and I'll take a look later to see if anything stands out.

If I recall correctly, the setting to hide the 'Forum Rules' link in the header was breaking some stuff. That one's already fixed for the next version, but if you've found another we can fix that's great too!

# ? Aug 26, 2019 19:10

novamute: Jul 5, 2006; o o o

astral posted:

I wouldn't be surprised if some specific option that applies to only those pages were breaking it. Feel free to PM me your current options (misc commands -> copy json settings string) and I'll take a look later to see if anything stands out.

If I recall correctly, the setting to hide the 'Forum Rules' link in the header was breaking some stuff. That one's already fixed for the next version, but if you've found another we can fix that's great too!

That did it! Glorious glorious keyboard nav and quick reply are back! THANK YOU!

# ? Aug 26, 2019 19:55

Flipperwaldt: Nov 11, 2011; Won't somebody think of the starving hamsters in China?

Way back I mentioned that the touch keyboard covered the quick reply window. That's now fixed on Microsoft's end.

# ? Aug 26, 2019 19:57

astral: Apr 26, 2004

Flipperwaldt posted:

Way back I mentioned that the touch keyboard covered the quick reply window. That's now fixed on Microsoft's end.

# ? Aug 26, 2019 21:30

rabble rabble: Mar 24, 2015; Nap Ghost

astral posted:

https://bintray.com/salr/salr-firefox/download_file?file_path=something_awful_last_read_redux-2.1.8.13a12-an%2Bfx.xpi is the last signed version; not 100% if they can prevent it from installing or not since it's disabled on a.m.o. but we'll see!

I just had to reinstall and was a twitchy mess until I found this

oh god please never leave me salr

# ? Sep 10, 2019 03:07

Adbot: ADBOT LOVES YOU

# ? Apr 19, 2024 19:04

Trastion: Jul 24, 2003; The one and only.

Did SALR break on Chrome for anyone else? I don't think there was an update or anything but my Mouse gesture stuff stopped working and I cannot handle the forums without it...

# ? Sep 19, 2019 16:42

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > SALR Redux - More browsers, better taste! (chrome users: uninstall the button ext!)

«‹›21 »