Coding Horrors: You can gather all your technical debt into one easy framework!

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > The Cavern of COBOL > Coding Horrors: You can gather all your technical debt into one easy framework!

«‹›2 »

Mikey-San: Nov 3, 2005; I'm Edith Head!

meh

# ¿ Apr 8, 2008 15:28

Adbot: ADBOT LOVES YOU

# ¿ Apr 27, 2024 00:33

Mikey-San: Nov 3, 2005; I'm Edith Head!

GT_Onizuka posted:

Thanks

No no, it wasn't in response to anyone. I posted something, realized I spoke too quickly and the post was bad, and removed it. That's all. I would've just deleted the post if I could've.

# ¿ Apr 9, 2008 06:48

Mikey-San: Nov 3, 2005; I'm Edith Head!

yaoi prophet posted:

Sometimes I think that if CoC had it's own YCS/helldump/BYOB style subforum, many people would have a hell of a time telling the difference.

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > Goto Considered Helpful > so is it just me or is coldfusion kinda faggy or what

# ¿ Apr 25, 2008 23:42

Mikey-San: Nov 3, 2005; I'm Edith Head!

Drx Capio posted:

GCH is leaking!

quotin dis for truth

# ¿ Apr 26, 2008 01:57

Mikey-San: Nov 3, 2005; I'm Edith Head!

this guy is totally GCH

# ¿ Apr 26, 2008 05:46

Mikey-San: Nov 3, 2005; I'm Edith Head!

Lexical Unit posted:

I can one-up that. A struct with longitude, latitude, and longititude. No longititude is not different that longitude, it is just there because somehow longititude got into a spec sheet and it was easier to add to the spec than change it. Old code expects longititude to be populated, new code expects longitude to be populated. Good night, and good luck.

I see this and raise you:

http://en.wikipedia.org/wiki/Referer

# ¿ May 6, 2008 18:20

Mikey-San: Nov 3, 2005; I'm Edith Head!

code:

if (!isset($bravo)) {
   $blah = here($something);
} elseif (isset($charlie)) {
   $blah = here($charlie);
} else {
   $blah = nothere();
}

This kills me. The same-line braces are just so noisy. I don't mind collapsing if/else statements like this, but untangling/ignoring the superfluous braces drives me nuts.

Planning ahead with your code formatting is akin to premature optimization, in my book. If later you need to add extra lines (and therefore, braces), okay, you can do it later. Making it as readable as possible at the moment someone is looking at it is more important than worrying about how you might need to format it later.

edit: clarity

Mikey-San fucked around with this message at 22:11 on May 9, 2008

# ¿ May 8, 2008 15:57

Mikey-San: Nov 3, 2005; I'm Edith Head!

wolf_man posted:

longer statements I do the same as Mikey-San

code:

if (!isset($bravo)) { 
	$blah = here($something); 
} elseif (isset($charlie)) { 
	$blah = here($charlie); 
} else { 
	$blah = nothere(); 
}

I don't do that. I said I can't stand the superfluous braces.

quote:

my thinking is, if your not able to read my code, or at least figure it out, then you shouldnt be looking at it in the first place

My thinking is, in this order:

1. Adhere to the coding standards of the project you're working on.

2. If I don't strive for readability for others who might read my code later, I shouldn't be writing it in the first place.

# ¿ May 8, 2008 17:58

Mikey-San: Nov 3, 2005; I'm Edith Head!

JoeNotCharles posted:

"whitespace" means any space, not just newlines. No whitespace would be:

((!isset($bravo))?($blah=here($something))(isset($charlie))?($blah=here($charlie))$blah=nothere()));

Which is why this whole argument was so weird - as far as I could tell, the original poster was complaining about "if(!isset($bravo))", which is hard to read because the "if" is all jammed up against the bracket, and then everyone argued about where the newlines should go.

EDIT: I think I'll leave those smilies there: they're pretty appropriate.

I'm arguing about bracket placement HELLO GET IT RIGHT :argh:

To contribute:

I once worked on a project that had a feature for integrating with Flickr. We inherited the source base from an outsourced 1.0 (almost worthy of its own wtf thread), where instead of "Flickr", or even "Flicker", it was called "Ficker". Now whenever I think about Flickr, all I can hear in my head is "Ficker".

One day, I got so annoyed by seeing it that I burned an hour and got rid of it all. That was not a fun commit.

# ¿ May 10, 2008 03:35

Mikey-San: Nov 3, 2005; I'm Edith Head!

I think Torvalds means "stupid" in the sense that "it only knows a set of predefined rules". It cannot determine the intent of the programmer, so while it's good at what it does, it can't think. It's "dumb".

Yeah?

# ¿ May 13, 2008 17:06

Mikey-San: Nov 3, 2005; I'm Edith Head!

TSDK posted:

Whilst that is a reasonable statement about compilers, I'm still worried that someone's default attitude to warnings would be "I'm a programmer, I know best". Compiler warnings and sanity checking tools are there to help - as soon as false positives start creeping in unchecked, then they become useless. There's nothing worse than finding a bug the compiler was warning you about, but you didn't see it because it was hidden amongst a mass of 'harmless' warnings.

Yeah, it's a thorny bush. When can a programmer determine that a compiler warning is truly safe to ignore? At what point does the compiler know better, despite not "knowing" anything about the intent of the code? And how does the programmer know when which scenario is true?

# ¿ May 13, 2008 17:34

Mikey-San: Nov 3, 2005; I'm Edith Head!

Jungle Bus posted:

But that's not "stupid," it's "not-smart."

"Semantics"

# ¿ May 13, 2008 19:34

Mikey-San: Nov 3, 2005; I'm Edith Head!

Holy poo poo, ydnar. There is a name I have not seen in years.

http://www.ydnar.com/
http://www.shaderlab.com/

Marathon fans (all seven of you) in the room may recognize the name.

Mikey-San fucked around with this message at 06:39 on Jun 4, 2008

# ¿ Jun 4, 2008 06:35

Mikey-San: Nov 3, 2005; I'm Edith Head!

Zakalwe posted:

Here's another coding horror. A student of mine refused to use a for loop. He wrote everything as a while loop

for(int i=0; i<5; ++i){
do_stuff(i);
}

was

int i=0;
while(i<5){
do_stuff(i);
++i;
}

Now they'll compile down to the same code 99.99% of the time, but it takes up more space, reads strangely to anyone else and the iterator now has scope outside of the loop. I never got a satisfactory answer from him as to why he did this.

It probably made more sense to him but he couldn't express why or how. That's sad, because I believe a majority of problems people have with code stem from an inability to delineate the nature of their thinking and the problems their thinking attempts to solve.

# ¿ Jun 15, 2008 18:53

Mikey-San: Nov 3, 2005; I'm Edith Head!

Zakalwe posted:

I know I've been guilty of the same thing. When learning C years ago (self taught) I had a habit of using (*foo).bar rather than foo->bar which some people would call horrific.

Hey, at least you knew how to use pointers. :v:

# ¿ Jun 15, 2008 23:42

Mikey-San: Nov 3, 2005; I'm Edith Head!

Flobbster posted:

Then there should be a comment indicating exactly what you just said

And when you do that, the code isn't necessary at all. Don't rely on code to convey intent, that's what comments are for. If you're worried about a future traveler not knowing to look for a potential situation and handle it differently, make a note in a comment.

# ¿ Aug 28, 2008 19:54

Mikey-San: Nov 3, 2005; I'm Edith Head!

# ¿ Nov 26, 2008 19:21

Mikey-San: Nov 3, 2005; I'm Edith Head!

subreality posted:

The same guy also wrote a login.php that went a little something like this:

php:

<?
  $logged_in = false;

  $users = mysql_query("SELECT * FROM users");

  while ($row = mysql_fetch_assoc($users)) {
    if ($row['username'] == $_POST['username'] && $row['password'] == $_POST['password']) {
      $user_id = $row['id'];
      $logged_in = true;
    }
  }
?>

Who gives a gently caress about this disaster when you're storing passwords in plain text in the database?

# ¿ Dec 5, 2008 09:22

Mikey-San: Nov 3, 2005; I'm Edith Head!

Rottbott posted:

There are several functions over 3000 lines in the C codebase I work with.

why

# ¿ Dec 22, 2008 19:58

Mikey-San: Nov 3, 2005; I'm Edith Head!

Don't get me wrong, I've seen really long functions in C programs before, but 3,000+ lines for one function? What's the weird case here that makes such a beast necessary?

# ¿ Dec 23, 2008 01:26

Mikey-San: Nov 3, 2005; I'm Edith Head!

quote:

Okay, 3000 lines *is* a bit much. But splitting up functions just for the sake of bringing per-function line count to some arbitrary maximum isn't a good idea.

Agreed. 3,000 just struck me as whoa, slow down partner in most situations.

quote:

Language interpreters regularly end up like this, although "large functions" tends to be the least of the craziness. But if you're worried at all about interpreter performance, you really can't afford to make a function call per instruction or AST node.

Sounds reasonable.

quote:

Well regarding 3000 line functions, they're only sensible when the level of complexity is very low, like when 2975 lines are used to fill a static array.

I certainly hope you don't need to do this very often.

# ¿ Dec 23, 2008 05:34

Mikey-San: Nov 3, 2005; I'm Edith Head!

That Turkey Story posted:

He's also really freakin gay.

forgot to quote dis here

# ¿ Dec 23, 2008 05:36

Mikey-San: Nov 3, 2005; I'm Edith Head!

awesmoe posted:

Why is your dev server running different versions of stuff than your live server?

# ¿ Jan 1, 2009 03:48

Mikey-San: Nov 3, 2005; I'm Edith Head!

hexadecimal.txt all up in this page

e: i kid, i kid

# ¿ Jan 7, 2009 20:26

Mikey-San: Nov 3, 2005; I'm Edith Head!

hexadecimal posted:

My WTF is really because I have trouble reading my own code, which is not good. Probably should never use 3 ternary operators on same line.

Probably?

quote:

drat I suck.

# ¿ Jan 8, 2009 23:23

Mikey-San: Nov 3, 2005; I'm Edith Head!

Mustach posted:

High as gently caress

The Something Awful Forums > Discussion > Serious Hardware / Software Crap > The Cavern of COBOL: if (!(hexadecimal ^ high)) { ++posts; }

# ¿ Jan 9, 2009 01:49

Mikey-San: Nov 3, 2005; I'm Edith Head!

Sergeant Rock posted:

Guys, this isn't strictly a coding horror, but I thought this was the right thread:

How much flour should I use when making dumplings for a goulash? I always have problems with putting too much or too little. TIA.

little babby can't follow a recipe

# ¿ Feb 9, 2009 11:08

Mikey-San: Nov 3, 2005; I'm Edith Head!

Avenging Dentist posted:

I want my password to be Bender! o-(8 E|

5318008 is the best password

# ¿ Mar 13, 2009 23:38

Mikey-San: Nov 3, 2005; I'm Edith Head!

royallthefourth posted:

No matter how many words you put inside the braces you must ask yourself:
am I really doing anything?

It's a pretty clever way to find out if the compiler accidentally generates new code for you.

# ¿ Mar 29, 2009 23:25

Mikey-San: Nov 3, 2005; I'm Edith Head!

Avenging Dentist posted:

A question so bad, even StackOverflow shits on it.

Idea: Post code to Stack Overflow that was pulled from highly rated answers previously found on Stack Overflow, pretending it's yours. Ask for feedback.

"Is it possible for a turd to eat itself?"

# ¿ Apr 27, 2009 23:08

Mikey-San: Nov 3, 2005; I'm Edith Head!

Everybody needs to vote that up.

# ¿ Apr 28, 2009 11:01

Mikey-San: Nov 3, 2005; I'm Edith Head!

sex offendin Link posted:

Are we really having an argument about code quality in the game industry? That's like discussing the environmental impact of Formula 1 cars.

code:

// drunk, fix later

# ¿ Jul 1, 2009 02:59

Mikey-San: Nov 3, 2005; I'm Edith Head!

dancavallaro posted:

http://forums.somethingawful.com/showthread.php?noseen=0&threadid=3178624

That thread is terrible.

Bhaal posted:

Being familiar with .NET could look extra appetizing on your resume if your PR/marketing duties are largely web-oriented.

Yes, someone who doesn't know any language and is asking about learning challenges should start with .NET because it'll look awesome to marketing dudes.

It looks like the OP is asking for the challenges people have dealt with, not recommendations for a first languages to learn. Why are people posting poo poo like this?

mrbass21 posted:

If you choose linux for your compiler

# ¿ Aug 2, 2009 02:32

Mikey-San: Nov 3, 2005; I'm Edith Head!

BigRedDot posted:

I work on sonar systems for submarines, I can say confidently that regular expressions are not at all an integral part of the programming we do.

I find it hard to believe that you could extract those little blips accurately from the ocean without some kind of regular expression. :colbert:

# ¿ Aug 3, 2009 21:52

Mikey-San: Nov 3, 2005; I'm Edith Head!

quote:

There is a really simple reason we owned PerlMonks: we couldn't resist more
than 50,000 unencrypted programmer passwords.

quote:

the administrators notified the owners of the exposed accounts and forced a reset of all their passwords.

problem solved guys go home nothing to see here

# ¿ Aug 4, 2009 01:21

Mikey-San: Nov 3, 2005; I'm Edith Head!

Ryouga Inverse posted:

Don't check in commented out code because you're half done with it. Check in only code that builds.

Fun way to stop people from checking in code that breaks the build: set up your VCS to notify a build machine every time someone checks in changes. Have your thankless robot build the project on every commit. When the build fails, your robot fires off an email to everyone:

THE loving PROJECT DOESN'T BUILD NOW
YOU CAN THANK: <PERSON>
BECAUSE OF HIS OR HER CHECK-IN: <REVISION NUMBER>
GO YELL AT THIS PERSON

edit: doesn't stop simple human mistakes, but eventually people get the message and stop doing reckless poo poo

Mikey-San fucked around with this message at 02:25 on Sep 12, 2009

# ¿ Sep 12, 2009 02:22

Adbot: ADBOT LOVES YOU

# ¿ Apr 27, 2024 00:33

Mikey-San: Nov 3, 2005; I'm Edith Head!

UraniumAnchor posted:

In my last job the 'big boss' checked in a piece of code that was k<=30 instead of k<30 and caused some 3rd-level damage. That one was fun to track down.

Does the 'big boss' not like to have other engineers review his changes before committing?

# ¿ Oct 4, 2009 23:03

The Something Awful Forums > Discussion > Serious Hardware/Software Crap > The Cavern of COBOL > Coding Horrors: You can gather all your technical debt into one easy framework!

«‹›2 »

GT_Onizuka posted:

yaoi prophet posted:

Drx Capio posted:

more falafel please posted:

code:

Lexical Unit posted:

code:

wolf_man posted:

code:

quote:

JoeNotCharles posted:

TSDK posted:

Jungle Bus posted:

Zakalwe posted:

Zakalwe posted:

more falafel please posted:

code:

Flobbster posted:

subreality posted:

php:

Rottbott posted:

quote:

quote:

quote:

That Turkey Story posted:

awesmoe posted:

hexadecimal posted:

quote:

Mustach posted:

Sergeant Rock posted:

Avenging Dentist posted:

royallthefourth posted:

Avenging Dentist posted:

sex offendin Link posted:

code:

dancavallaro posted:

Bhaal posted:

mrbass21 posted:

BigRedDot posted:

quote:

quote:

Ryouga Inverse posted:

UraniumAnchor posted: