|
So with the new top buttons, this happens with the page navigator for SALR: Perhaps hide the button in the lower right corner? (I modified \js\salr.js to have: code:code:Another possibility would be to move the navigator over I guess, but if the Firefox thread is any indication, I think people would prefer the location of the navigator and get rid of UP button.
|
#
¿
Jun 16, 2012 23:40
|
|
|
|
| # ¿ Apr 25, 2024 15:59 |
|
|
Aatrek posted:I like my buttons ferg used append instead of prepend in salr.js on line 322.
|
|
#
¿
Jan 4, 2013 08:03
|
|
|
Vykk.Draygo posted:On single page threads, the dropdown menu on the page navigator is blank (I think it used to just say "1") and all the buttons look clickable even though there are no other pages to navigate to. Not a huge deal, but it keeps messing with me because I look at those buttons to tell if I'm on the last page of a thread or not.
|
|
#
¿
Jan 8, 2013 19:51
|
|
|
Vykk.Draygo posted:I'm on v1.5.5 and mine looks like this on single page threads.
|
|
#
¿
Feb 4, 2013 06:27
|
|
|
wormil posted:Is the imgur doohickey still broke for everyone or is it just me?
|
|
#
¿
Feb 26, 2013 06:15
|
|
|
With school projects wrapping up, I'll try and do some work on this as it's a really useful addon. I'll push out an update that'll at least address the single page thread count being blank on the weekend as well as look at the open updated thread thing that was reported last weekend. Rohaq posted:Anybody else getting their SA tabs freezing and failing to respond when SALR is enabled?
|
|
#
¿
Apr 3, 2013 00:26
|
|
|
pik_d posted:I'm having a problem where k/h for previous page aren't working. I'm not actually sure if they ever worked, since I don't use them that often, but all of the other keyboard shortcuts work fine except for them. Is anyone else having this issue? The actual text button for Open Updated Threads does work though, and it just requires moving the code out of salr.js to the bottom of hotkey-manager.js, as well as adding a conditional for if(curr_page == 'usercp.php') within the switch(event.keyCode) code. A fix is forthcoming as I take over development of SALR in the next couple days.
|
|
#
¿
Apr 8, 2013 16:55
|
|
|
 SomethingAwful Last Read Redux ReleasedSo this is the first release of my continued support of the extension and it contains the recent pull requests submitted by myself to fix the single page display error as well as retina image fixes. Keyboard support fixes will be forthcoming as I regain internet at my home tomorrow. Continue using this thread and what have you for all bugs that you encounter. Ferg should be updating the links in the OP to my github fork for anybody that wants to help develop and what have you.
|
|
#
¿
Apr 8, 2013 20:30
|
|
|
Athenry posted:My buttons are doing this again with 1.5.6:
|
|
#
¿
Apr 8, 2013 23:57
|
|
|
V1.5.7 RELEASEDChangelog posted:
There may be some regressions on the settings page, but at the moment, the most grevious one (the broken custom icons) was fixed, as well as an update to fix the Open Updated Threads keyboard shortcut (by default hitting b twice on Usercp.php/bookmarkthreads.php). On the list of things to do in order of importance: - Fix other keyboard shortcuts (back a page for example) - Omnibar Grenade Link (I vaguely remember it so if a goon would explain what exactly it did I'd appreciate it) - Open Updated Threads was a button? (again, I never used this feature so an exact explanation of what they'd like it to be would be appreciated as it's currently just a text link on the bookmark thread pages) - Hide threads option (using bookmark star) in settings is broken - Update settings page to not have different color/style than forums - Look into if I can reproduce tabs freezing while using SALR Let me know if I'm missing an issue here. e: added couple stuff to the to-do list Master_Odin fucked around with this message at 03:44 on Apr 11, 2013 |
|
#
¿
Apr 9, 2013 05:15
|
|
|
Cartesian_Duelist posted:Is it possible to have a "Hide" button for threads? Ignore bookmarks with a <star> Which seems to be broken (as well as out-of-date as there's no more blue star?) though so I guess that's a thing that needs fixing. Bloody Hedgehog posted:It opened a drop-down menu with links to all the forums/subforums. e: unpronounceable posted:I can only speak for myself, but highlighting of my friend's posts isn't working. It will highlight my posts, quotes of mine, and admin/mod names, but not my friends. Master_Odin fucked around with this message at 07:05 on Apr 9, 2013 |
|
#
¿
Apr 9, 2013 06:58
|
|
|
pik_d posted:This quoted post is from 3 years ago but this has just happened to me after updating to 1.5.7. When it happened to qbert it was because some code got deleted, could that have happened again? e: pull request submitted, and hopefully will have a resolution forthcoming where you guys don't need to install anything else. e2: Turns out there's more to the issue as actually fixing this requires moving to a new extension version within chrome, which breaks the extension from working. So this may take some time to actually fully fix. Turns out I have till September to get this fixed or else it'll completely stop working! sharktamer posted:What that setting actually does is ignore bookmarks with a certain colour when using the "open all updated threads" link. LastInLine posted:I think the mouse gestures are broken in Redux. Those and poster highlighting are pretty much the only things I use. Master_Odin fucked around with this message at 19:20 on Apr 9, 2013 |
|
#
¿
Apr 9, 2013 14:25
|
|
|
Sad Panda posted:Thank you for taking this on, it's definitely appreciated.
|
|
#
¿
Apr 10, 2013 00:28
|
|
|
LastInLine posted:Edit: I found out what's causing the problem--checking the option to change the last page link to the last three pages disables both the Quick Reply Box and mouse gestures. Disabling the option fixes both issues. It's fixed anyway and appears like:  which I'm assuming is correct as this is another feature I never used personally. Anyway, I'll push out 1.5.8 and try and get an updated browser button done over the weekend. e: Master_Odin posted:- Friend post highlighting broken Master_Odin fucked around with this message at 03:52 on Apr 11, 2013 |
|
#
¿
Apr 11, 2013 01:30
|
|
|
kri kri posted:Can you add an option to disable thread tags option like the salr for firefox has/had?
|
|
#
¿
Apr 11, 2013 03:43
|
|
|
LastInLine posted:In the same vein, it used to be that you could add Configure SALR to the menu then hide the top menu and it would appear in the bottom one and have no menu at all at the top. Now adding Configure SALR does not do it for the bottom menu and furthermore it appears at the top even if you disable the top menu altogether. 1. Add Configure SALR to bottom menu (fixed) 2. Add option to remove top/bottom navigation bar (independent of each other?) 3. Don't display "Configure SALR link" at all if the menu is not displayed? As it is, SALR is coded to always appear if the option is enabled, and I think that makes sense, but perhaps just have it appear a bit nicer? LastInLine posted:Honestly if I could have any wish I'd rather the SALR and grenade icon that appears in the top left of a thread lead to the options instead of it just being there looking out of place with the wrong font. Sad Panda posted:My main issue is that when I click on it, it doesn't do anything. Alternatively, can you take a screenshot of your settings page so I can configure my SALR to be the same as yours as I'm having issues replicating the issue. Master_Odin fucked around with this message at 16:20 on Apr 11, 2013 |
|
#
¿
Apr 11, 2013 15:52
|
|
|
LastInLine posted:
JohnnyCanuck posted:Is there any way to force SALR to use the currently open tab yet, or does it still open everything in new tabs? Kazy posted:Would it be possible to add some way to get to the right-click menu when mouse navigation is enabled? e: 1.5.8 will be released later tonight when I get home from class: Change Log posted:### v1.5.8 (4/11/2013) Master_Odin fucked around with this message at 17:41 on Apr 11, 2013 |
|
#
¿
Apr 11, 2013 17:32
|
|
|
Sad Panda posted:I'm getting an error, but it's in miscellaneous bindings:236 e: Hm, while I don't get the error, it doesn't seem to work for me either. However, it does work on 1.5.8. I'm guessing it had to do with the Display first/last 3 pages setting. When I release 1.5.8 tonight, please let me know if this continues. Master_Odin fucked around with this message at 18:15 on Apr 11, 2013 |
|
#
¿
Apr 11, 2013 18:04
|
|
|
Sad Panda posted:When I load up a thread I get the following errors...
|
|
#
¿
Apr 11, 2013 21:07
|
|
|
SirJoeKCB posted:Uh... First, can you check if chrome is throwing an error? Go to Tools -> Developer Tools. This will open a box at the bottom of the screen. Click on the "Console" tab, and then refresh the 'usercp.php' page and see if an error appears there (the error should have on the right side 'salr.js' and some numbers. I need that really.) Alternatively, can you take a screenshot of your settings page so I can configure my SALR to be the same as yours as I'm having issues replicating the issue. As I have no idea as turning on all settings didn't do this and I have no idea why those specific posts would mess things up? 
|
|
#
¿
Apr 11, 2013 22:10
|
|
|
SALR Redux Browser Button Released The code that made this possible will make it upstream into the actual extension for the omnibar icon which I'm guessing is broken seeing as how I can't get it to even appear! SirJoeKCB posted:There were no javascript errors either on the control panel or this thread, but I've since restarted Chrome and it's not happening anymore. Prior to that it had persisted through both closing/reopening the page and toggling the extension (worked fine without SALR enabled). 
|
|
#
¿
Apr 12, 2013 07:51
|
|
|
Zen Punk posted:There's one thing I brought up earlier - chrome's right-click context menu doesn't show up on forums pages when you have mouse gestures enabled, even if you click and release without selecting a gesture button. It does show up in firefox, don't know if it's possible in chrome. Ferg said there was something funny going on he didn't want to mess with. However, I am looking into seeing if I can't get the same overlay to appear with a keyboard shortcut as it seems the best compromise and while I have it appearing on an alt key press, all that remains is actually using the buttons. Stare-Out posted:I still can't seem to get the quick reply box to go away with the Escape button for some reason. Using newest stable Chrome on OSX 10.7 with newest SALR Redux. There's also a weird thing with the live preview where pictures posted in the thread block out the preview window:
|
|
#
¿
Apr 12, 2013 14:39
|
|
|
Stare-Out posted:All right, good to know they're being looked into. Appreciate you working on this, too. Thanks! e: Yeah, the imgur is broken in the same way the browser button was. The extension security policy became stricter in the new version of them, so inline javascript is completely disallowed. Have to rewrite the handler methods, so it might not be as complicated as I'd expect. Probably bump this up to something to try and do for next release. Master_Odin fucked around with this message at 16:19 on Apr 12, 2013 |
|
#
¿
Apr 12, 2013 16:15
|
|
|
Stare-Out posted:I had the timg fix on but I tried turning it off and it didn't fix the live preview bug, it only happens with timg images though, as far as I can tell regular img-tagged images don't obscure the live preview window. I have keyboard navigation off but quick format keys are enabled under the quick reply box section (which is obviously enabled as well). If there's an easy way to post all the settings I have I'd be happy to hear it. So the hotkey is broken when you don't have the hotkey manager going right? Like you just want the hotkey to close the Quick Reply, and when it's set like that, it doesn't work? If so, yeah, I get that issue as well. I'm guessing expected behavior is that hitting esc while Quick Reply is open will close it regardless if you have global hotkeys set?
|
|
#
¿
Apr 12, 2013 17:21
|
|
|
Master_Odin posted:It has something to do with that the right mouse down/up is getting overloaded to make the overlay appear/disappear. It seems that you get either/or, and there's no real way to make it appear anyway as far as I'm aware so long as no error is thrown and something isn't broken. Googling only really returns results on either a) building your own righclick or b) disabling rightclick all together making the issue hard to see if it is even possible. Stare-Out posted:I just noticed that with keyboard navigation on, the Esc thing works fine, but it used to work with keyboard navigation off as well if I recall. Now that I think about it, having keyboard navigation on isn't a bad thing at all and I might as well keep it on as it's actually pretty useful.
|
|
#
¿
Apr 12, 2013 18:52
|
|
|
Mak0rz posted:Just a suggestion to (possibly) make your life easier: Is there any way to program a button into the settings that dumps config/browser version/etc information onto the clipboard for easy posting rather than asking people to send you screenshots of their settings pages? Also, the next version of the extension may break things as I update the jQuery the extension uses. I'm going to try and test as much as I can, but just an fyi I guess. Master_Odin fucked around with this message at 23:07 on Apr 12, 2013 |
|
#
¿
Apr 12, 2013 23:05
|
|
|
Sad Panda posted:On 1.5.8 and still nothing happens. Only console error now is The good news: I have figured out the issue behind it and it's basically the forum revamp to the stars changed how they're defined (they're now classes, no longer images within the html). This means that if you set that option, it breaks SALR. Now, since this is a game-breaking issue and I feel dumb for not catching it because I'm bad at setting settings, I'm going to split 1.6 release and get this and two other things fixed for 1.5.9, with 1.6 coming later on (which will be postponed a bit more so I can hopefully get imgur working as well as fully test the changes to the code that updating the jQuery did). Expect the patch to hit tomorrow.
|
|
#
¿
Apr 14, 2013 00:35
|
|
|
1.5.9 Released changelog posted:### v1.5.9 (4/14/2013) Update the extension to get those sweet changes!
|
|
#
¿
Apr 14, 2013 16:27
|
|
|
100 HOGS AGREE posted:It seems to open all the threads twice each for me. Progress! Try setting the value in that dropdown to a star you don't use for now and test it again.
|
|
#
¿
Apr 14, 2013 19:22
|
|
|
Thanks Ferg!LastInLine posted:I think this is broken. The menu and the gesture icons appear, but moving the cursor to the icons does nothing. That would occasionally happen before and a secondary click on the desired icon usually caused it to activate but this time there was no way to make the icons go away. I just had to refresh the page and disable the option. However, after the setting is defined, it seems to work fine for me where if I have both, it works, but the right menu appears (and works) and if the second one isn't set, no right click menu. I'm going to put out 1.5.10 that fixes these small bugs as well as add a "setting dump" page. So if it's still broken, I'll be asking for you to give me your settings then because it might be another part of the extension messing things up. Also, as a user who uses the mouse gestures, do you have any preference for what the bottom button would be? As of now, I don't think it has a use, and I feel setting it to something like "usercp.php" would be useful as hell. 100 HOGS AGREE posted:Yep that did it. Fix that and split up the "Display threads with new posts first" into two options so I can have it on only in the UserCP and not the forums at large and that's basically all the features I want forever. Master_Odin fucked around with this message at 14:27 on Apr 15, 2013 |
|
#
¿
Apr 15, 2013 14:23
|
|
|
1.5.10 releasedChangelog posted:### v1.5.10 (4/15/2013) It seems that the right click context menu acts funky on my laptop (but not my desktop) where the action to use it properly is: 1) Hold right click briefly so I see overlay and context menu 2) Let go right click so context menu disappears but overlay remains 3) Right click on proper box I want to go to 4) Don't hit anything on the second context menu to appear while the page is transitioning. It's a weird effect and I'm honestly not sure how to fix this beyond get it so hitting alt or something would also bring up the overlay to free it from right click for those that want the context menu at this time. If there's some other issue at work (ie. really not working), please use the new dump settings button on the bottom of the settings page, post it to pastebin and give it to me?
|
|
#
¿
Apr 15, 2013 17:59
|
|
|
RandomPauI posted:I'd run into the undefined problem too and had to disable SALR. The trigger word that caused the error to pop up in a post was literally "undefined". Luckily v1.5.10 of Redux offers a way to dump the settings for easy copy/pasting!
|
|
#
¿
Apr 15, 2013 18:31
|
|
|
Zen Punk posted:The rightclick context menu was working just fine for me on my desktop. I'll see how it works with .10 when I get home. LastInLine posted:Edit: That time it both opened another instance of this thread and the Options screen. I enabled the right click menu but it still has the same problem in that I can't select any of the arrows. I'd rather just have it do the gestures unless you use a modifier (Control, Option, or Command doesn't matter to me), having both appear just doesn't work. And it worked on my linux laptop as well. Holding right click gets overlay to appear, then move mouse over option, release to select, then left click to get rid of context menu on my desktop. How I did it on my laptop is posted above. I'm not sure why it's broken for you guys, but works fine for me (and then Zen reports it worked fine before, but now it broke (which really doesn't make sense as I only changed a conditional to be the opposite of what it was ($ != true instead of == false, more robust if setting is undefined). I'm absolutely baffled on why this is happening. I would say perhaps that if you guys use the "Dump Settings" button at the bottom of the page, copy the contents of the page and put it on pastebin.com, and then give me the link, I'll take a look at it. It might be another setting that's breaking it for whatever reason because I don't see it? I might be able to apply a key modifier to make either the overlay appear or not on the right click actually by changing the rightmousedown function now that I figured out how the context menu was originally disabled. I'll look into it as I agree the current solution is inelegant as all hell and you really end up with a poor mix of both worlds. LastInLine posted:The Configure SALR link now leads to this thread
Master_Odin fucked around with this message at 04:34 on Apr 16, 2013 |
|
#
¿
Apr 16, 2013 04:31
|
|
|
LastInLine posted:This is on a MacBook Air, so it was cmd-click to get the options to come up in a new tab. I did it three or four times and each time only a new tab with this thread (at the first post) loaded. Then it opened that plus the options finally. I'm at work at the moment but I'll see if I can't reproduce it. LastInLine posted:As for the gestures, it doesn't work like the video at all for me on OSX. Both the gesture squares and the secondary click menu open simultaneously when you initiate the right click obscuring the bottom two-thirds of the right gesture pad. Holding and moving to a pad then releasing does nothing. Releasing will allow you to select and click an option on the right click menu, but none of the gesture pads will do anything with either single click, double click, or a right click. Here is my settings dump. Anyway, alt key now can be used to turn on/off overlay and turn off/on context menu which works way better I think (and should not be computer dependent unless you lack an alt key or something). Bottom button now also refreshes the current page. I'll push the update later today. Master_Odin fucked around with this message at 19:25 on Apr 22, 2013 |
|
#
¿
Apr 22, 2013 18:32
|
|
|
LastInLine posted:Do you know how the Alt key will translate to OS X? I only ask because Alt is only accessible by hitting Fn+Opt so to open the menu it would be Fn+Opt+Cmd click and while it's doable it'd be nicer to have the modifier be a single key. If it's not possible or if it just translates to Opt I can live with it. I've been living without it for so long I just forget the menu exists.  e: Actually, I'll just have it trigger on option/alt. I think they may have the same keycode. Time to ask my friend to borrow his computer. Thanks for letting me know about this though. Master_Odin fucked around with this message at 20:11 on Apr 22, 2013 |
|
#
¿
Apr 22, 2013 20:07
|
|
|
Master_Odin posted:Macs, the bane of my existance clearly. Anyway is v1.5.11 released which hopefully is the last drat patch on mouse gestures (beyond some style stuff and minor changes to the top button I guess). Changelog posted:v1.5.11 (4/22/2013) - "I really hate mouse gestures" Master_Odin fucked around with this message at 07:34 on Apr 24, 2013 |
|
#
¿
Apr 24, 2013 07:32
|
|
|
v1ld posted:Friend Post Highlighting works for me only in threads where they're also the OP. They're not highlighted in other threads. Does this work for anyone else? The highlight friends in threads where they're the OP works irrespective of whether OP Post Highlight is selected.
|
|
#
¿
Apr 29, 2013 17:54
|
|
|
Endymion FRS MK1 posted:Why did my new thread button disappear? e: Note, the setting you have on is called "Hide the "Post" button in threads". It used to affect forum display (but that's fixed), so you shouldn't see the button in threads if it's on though now. Changelog posted:### v1.5.12 (5/1/2013) e: while friend highlighting works, I have to test it for having a large number of friends in-case more action is required. For now, I've tested on <10 friends. Master_Odin fucked around with this message at 07:43 on May 1, 2013 |
|
#
¿
May 1, 2013 07:22
|
|
|
Changelog posted:### v1.5.13 (5/2/2013) So while you all can safely ignore the first thing, the rest is all applicable. This should allow for better color matching between SALR options and the actual forum/usercp views, as well as update on the quote box being the main things in the update. I guess next is to add a way to have a "Pop-Up" help box that explains some things (such as having to go to Usercp.php to have friend highlighting, or hotkeys for Keyboard Navigation, or having a certain setting on to use OP highlighting).
|
|
#
¿
May 2, 2013 20:15
|
|
|
|
| # ¿ Apr 25, 2024 15:59 |
|
|
Vykk.Draygo posted:Here's a strange issue: I was using the thread search at the top of the page to search for a word in the Adam Carolla Show thread in RGD that I know is in the thread, but it says no results found. Any word I search, even if I'm looking right at the word, comes back with no results. I don't know if this is an extension issue or a forums issue. Lprsti99 posted:So, I don't suppose the "don't convert images in a post with a NWS/NMS warning" could be extended to posts that have the literal strings "not work/mind safe" and "not safe for work," could it? Because I just got blasted by a huge picture of a harlequin baby right before I was about to pass out.
|
|
#
¿
May 6, 2013 20:01
|
|