|
Nice work with the port! This is exactly what was needed to tide people over until XenForo 2. Is there a most-updated repo for the Firefox changes, or just the zips Serfer has posted? I can help with getting it submitted / setting up an auto-update from the legacy Firefox version when it's ready. e: can help with stuff like data translation too so people can keep their notes and relevant settings from their legacy firefox install astral fucked around with this message at 03:57 on Dec 4, 2017 |
#
¿
Dec 3, 2017 21:40
|
|
|
|
| # ¿ Apr 26, 2024 07:59 |
|
|
Serfer posted:I see there's no longer any conversion capability built in, so it'll probably have to be an outside process to convert the notes from the sqlite file. No worries - just point me at the latest version (do you have a repository setup or just the zips?) and I can take care of the signing part. I don't mind maintaining any firefox-specific changes that can't be merged back into the main one. As for the user notes, it's just a question of converting from the sqlite like you said. What I was referring to though is I can do the data migration with the extension itself as long as the user is running a Firefox version less than 57 (for example, I and many others have been using the ESR). Master_Odin already mentioned they planned to integrate the extension+button extension as well, so make sure you guys aren't duplicating each others' work. 
|
|
#
¿
Dec 23, 2017 08:38
|
|
|
I've had a few spare minutes here and there tonight so I used them to get a small head start on things. Integrated the 100% compatible stuff from the posted zip with a few slight modifications into my fork repository so far. Need to work out a good way to support the manifest for cross-browser compatibility, since chrome will give a warning with the `applications` flag we will need for SALR for Firefox (because the extension uses certain APIs that require it) - haven't changed that part in the repository yet. Also need to integrate the other stuff from Serfer's zip (such as the change to the behavior of the down arrow in the page nav) as optional instead of replacing SALR Chrome's behavior wholesale, though, and I'll have to ask 'em about the (WIP?) changes to youtube URL matching. Initial testing seems pretty good, though. Thanks to Serfer for getting things started! e: also may have to figure out version numbering, since the legacy Firefox version is a bit higher (4.1.3), but it might not be a big problem if the manifest ends up having to be different anyway astral fucked around with this message at 09:21 on Dec 29, 2017 |
|
#
¿
Dec 29, 2017 08:38
|
|
|
Master_Odin posted:So correct me if I'm wrong but `applications` flag is used to give a minimum version of Firefox that'll run the app right? It looks like it was made non-mandatory since FIrefox 48 and then since this is a web extension API, it self limits itself to FF57+? Or without it the extension store or whatever would happily try and install the web extension version to old versions of FF that don't support the API? It's mostly used to set the extension's ID for Firefox. My research the other night turned up this note: quote:Some WebExtension APIs use the add-on ID and expect it to be the same from one browser session to the next. If you use these APIs, then you must set the ID explicitly using the applications key. This applies to the following APIs: which at a quick glance at least two are being used, so it'll probably be necessary.
|
|
#
¿
Dec 29, 2017 19:56
|
|
|
The last post button on the page navigator doesn't seem to serve any purpose outside of threads in Chrome SALR - I'd like to change it so that button doesn't appear outside of threads, then adjust the navigator width to compensate. Sound good? Also, there's a difference in behavior for that button in threads between Chrome and Firefox SALR - the chrome version seems to just scroll to the first unread post, if available, while the Firefox version performed the equivalent of clicking the 'Jump to last read post' button from your bookmark list or from a forum, which people like to use to keep up with fast-moving threads. Serfer replaced it with the Firefox behavior, but for the sake of integration and in case people were relying on the Chrome SALR behavior, I've gone ahead and set it up as a setting instead which defaults to the existing Chrome SALR behavior; the Firefox release itself can then adjust the default setting to switch to the old Firefox behavior.
|
|
#
¿
Dec 29, 2017 23:14
|
|
|
I've hidden the last post arrow for pages where it did nothing and also went ahead and cleaned up the styling a bit like we discussed. I further set the text-decoration to none on the navigator buttons to remove the tiny little underline between them: Before (screenshot from Chrome in user control panel):  After: (screenshot from Firefox, so some of the font/popup menu stuff looks different, but you get the idea)  Will package this set of stuff as another pull request a little later.
|
|
#
¿
Dec 30, 2017 02:39
|
|
|
Progress update: Got emotes working in Firefox, and about 1/3 done redoing that disabled/removed imgur thing so it'll work. 
|
|
#
¿
Jan 2, 2018 04:49
|
|
|
Malachite_Dragon posted:I've been having trouble getting the live preview thing to work, but that's more a QoL thing that can wait on the back burner. I couldn't reproduce this problem, but I was testing in Nightly so that may have been something that was fixed in a later Firefox, or I might have incidentally fixed it for Firefox in the rest of the quick reply fixes/updates I was working on (on that front, imgur is just about done, just need to do some cleanup/polish on it tonight). iospace posted:Question, will you be attempting to get the old pop-up style quick reply window working? It was great for pulling quotes off of other pages or other threads. Obviously it's not a "immediate fix" thing. It would be nice, yes, but not an immediate thing as you say.
|
|
#
¿
Jan 2, 2018 19:32
|
|
|
datajosh posted:Probably a good idea, this one is over 8 years old now I propose: SALR Redux - More browsers, even better taste! tithin posted:Maybe once the official Mozilla addon is available? Technically it is, though it's set as Experimental until it's less buggy and closer to being ready: https://addons.mozilla.org/en-US/firefox/addon/salr-redux/ Temporary extension download for the button extension that's compatible: https://bintray.com/salr/salr-firefox/download_file?file_path=salr-chrome-button.zip astral fucked around with this message at 01:03 on Jan 3, 2018 |
|
#
¿
Jan 3, 2018 00:54
|
|
|
Malachite_Dragon posted:I should have specified what the problem is; it will open just fine, but it won't actually, y'know, live-preview the post I'm working on unless I un-check and then re-check the box. I appreciate the clarification; the live preview updating part was working for me too, so just let me know if the changes in the next for-firefox release don't fix it for you.
|
|
#
¿
Jan 3, 2018 06:02
|
|
|
Master_Odin posted:Oh sweet, I was waiting for you to post this link and then I was going to start up a new thread. I'll do that now and it'll also feature working pictures of features not pointing to waffleimages! Sounds good. I'm mostly done with imgur uploading (as in it works nicely; I just need to do some final cleanup), but I've been sidetracked by some user bug reports. It turns out that Firefox has some very strange behavior where if third-party cookies are disabled, XHRs from content scripts to even the domain of the content the content script is running on top of get sent without credentials or origin information. This, combined with jQuery being naughty about parsing responses, led to the hilariously bad result of the unregistered boogeyman video playing on every forum page the user browsed if quick reply was enabled! I'm rewriting those calls to use the Fetch API instead, which shows as supported by all browsers chrome SALR can run on (including Safari 10.1+). I'm also feature detecting the presence of content.fetch to use instead if available - it's present in Firefox 58+ and sends the request as if it came from the content, enabling quick reply to work properly even if third-party cookies are disabled. Further, I'm adjusting how the responses are parsed to protect people until then. astral fucked around with this message at 23:12 on Jan 3, 2018 |
|
#
¿
Jan 3, 2018 23:05
|
|
|
|
| # ¿ Apr 26, 2024 07:59 |
|
|
ArtVandelay posted:Apologies for the stupid question, but how do I install this? In Firefox you can go to about :debugging and click "Load temporary addon" e: Progress update, pushed some commits into the pull request bucket including a fix for quick quote not working in single post pages and some compatibility updates. Also fixed an old bug where successful imgur uploads would get reported to whatever your active tab was instead of the one you were uploading in, so if you were uploading a big image and navigated to a different tab, you'd never get the image link added to the quick reply box. Still need to finish cleaning up/packaging up the rest of the quick reply fixes, including the emotes for Firefox, imgur uploading, and what I'll call the anti-boogeyman Firefox changes. astral fucked around with this message at 21:23 on Jan 4, 2018 |
|
#
¿
Jan 4, 2018 21:16
|
|