Register a SA Forums Account here!
JOINING THE SA FORUMS WILL REMOVE THIS BIG AD, THE ANNOYING UNDERLINED ADS, AND STUPID INTERSTITIAL ADS!!!

You can: log in, read the tech support FAQ, or request your lost password. This dumb message (and those ads) will appear on every screen until you register! Get rid of this crap by registering your own SA Forums Account and joining roughly 150,000 Goons, for the one-time price of $9.95! We charge money because it costs us $3,400 per month for bandwidth bills alone, and since we don't believe in shoving popup ads to our registered users, we try to make the money back through forum registrations.
«9 »
  • Post
  • Reply
astral
Apr 26, 2004

Out there.


Endymion FRS MK1 posted:

Perfect, thank you! Question though, why the different settings?

The Firefox version of SALR Redux tries to keep the color settings of Legacy SALR.

Adbot
ADBOT LOVES YOU

Nalin
Sep 28, 2007



Hair Elf

You know that "Convert webm/gfycat links to inline video" option? Can it be expanded to include imgur .gifv links? I've seen people somehow embed .gifv videos inside <img> tags on the forum and my Firefox doesn't show them. Is that happening for anyone else with Firefox?

astral
Apr 26, 2004

Out there.


Nalin posted:

You know that "Convert webm/gfycat links to inline video" option? Can it be expanded to include imgur .gifv links? I've seen people somehow embed .gifv videos inside <img> tags on the forum and my Firefox doesn't show them. Is that happening for anyone else with Firefox?



People putting gifv links inside img tags is a mistake that doesn't work for anyone; it's not something SALR should encourage.

The forums javascript embeds those if they're within url tags (whether you add the url tags yourself or let the forums do so automatically by just pasting the link).

Nalin
Sep 28, 2007



Hair Elf

I probably should have checked, but yeah, no browser will show it if it is inside <img> tags. Weird since I see it every now and then. I figured something like Chrome was just allowing it for whatever reason.

Flipperwaldt
Nov 11, 2011

Won't somebody think of the starving hamsters in China?



Nalin posted:

I probably should have checked, but yeah, no browser will show it if it is inside <img> tags. Weird since I see it every now and then. I figured something like Chrome was just allowing it for whatever reason.
The android app allows it. Just like it plain shows http linked images that work nowhere else.

Also when you do gifvs the proper way, they don't show up in post preview, so maybe you've got people hypercorrecting to img tags because they think they did it wrong when they didn't.

gary oldmans diary
Sep 26, 2005



Hell Gem

I broke the Quick-Reply box again. Is it the api.imgur.com dialog box preventing it from working? I've tried Allow and I've tried Deny.

astral
Apr 26, 2004

Out there.


gary oldmans diary posted:

I broke the Quick-Reply box again. Is it the api.imgur.com dialog box preventing it from working? I've tried Allow and I've tried Deny.

The permission shouldn't be a problem. Are you seeing the dialog box more than once? I don't think I've seen it since initially allowing it.

Quick reply normally breaks if you hit the forwards or backwards button before or after clicking it. I imagine the cache and the content script don't play well together.

gary oldmans diary
Sep 26, 2005



Hell Gem

Nah, it breaks when I try to change an SALR option. After that, I see the api dialogue if I try to uncheck the quick-reply box so I can check it again in hopes that that will get things back.

astral
Apr 26, 2004

Out there.


gary oldmans diary posted:

Nah, it breaks when I try to change an SALR option. After that, I see the api dialogue if I try to uncheck the quick-reply box so I can check it again in hopes that that will get things back.

Is this something you can reliably reproduce? If so, please walk us through the steps necessary to do so. Thanks!

gary oldmans diary
Sep 26, 2005



Hell Gem

I started disabling features (got things working again) and I think I've got it narrowed down.

Header/Footer Link Display Options
  Display Navigation menu links (checked)
      Forum Rules (unchecked)

seems to break SALR in various ways. Just keeping it checked for now.

These were the other options in that category I had selected other than Forum Rules in case there's any effect from combining:

gary oldmans diary fucked around with this message at Mar 23, 2019 around 06:35

Adbot
ADBOT LOVES YOU

astral
Apr 26, 2004

Out there.


gary oldmans diary posted:

I started disabling features (got things working again) and I think I've got it narrowed down.

Header/Footer Link Display Options
  Display Navigation menu links (checked)
      Forum Rules (unchecked)

seems to break SALR in various ways. Just keeping it checked for now.

Good find! I can see why - looks like it's hard-coded to check for an http:// link for the forum rules and the forums have changed it to an https:// link.

edit: fixed for the next release, which'll happen after I finish making the post history tracking migration stuff for Chrome

astral fucked around with this message at Mar 23, 2019 around 06:45

  • 1
  • 2
  • 3
  • 4
  • 5
  • Post
  • Reply
«9 »