|
If you have time today, could you please look at my PR? It's only 2 lines.
|
#
?
Aug 24, 2020 18:50
|
|
|
|
| # ? Apr 18, 2024 10:43 |
|
|
👍
|
|
#
?
Aug 24, 2020 18:52
|
|
|
lgtm
|
|
#
?
Aug 24, 2020 21:25
|
|
|
gfy
|
|
#
?
Aug 24, 2020 21:26
|
|
|
you should do this in go
|
|
#
?
Aug 24, 2020 21:27
|
|
|
approved. now gently caress off
|
|
#
?
Aug 24, 2020 21:30
|
|
|
um.. are you going to merge it?
|
|
#
?
Aug 24, 2020 21:57
|
|
|
yes its merged gas thread ban op
|
|
#
?
Aug 24, 2020 22:00
|
|
|
pram posted:lgtm
|
|
#
?
Aug 24, 2020 22:14
|
|
|
*no response for 2 months*
|
|
#
?
Aug 24, 2020 22:20
|
|
|
What the F*CK, guys? This piece-of-poo poo commit is marked for stable, but you clearly never even test-compiled it, did you? Seriously, WTF? I made the mistake of doing multiple merges back-to-back with the intention of not doing a full allmodconfig build in between them, and now I have to undo them all because this pull request was full of unbelievable poo poo. And why the hell was this marked for stable even *IF* it hadn't been complete and utter tripe? It even has a comment in the commit message about how this probably doesn't matter. So it's doubly crap: it's *wrong*, and it didn't actually fix anything to begin with. There aren't enough swear-words in the English language, so now I'll have to call you perkeleen vittupää just to express my disgust and frustration with this crap.
|
|
#
?
Aug 24, 2020 22:35
|
|
|
thats going to be the only message sent in the team slack channel all day and it won’t get touched
|
|
#
?
Aug 24, 2020 23:11
|
|
|
PR means per rectum
|
|
#
?
Aug 24, 2020 23:21
|
|
|
when I used to drupal it would literally 4 years for a one line change to be committed. open sores is fun
|
|
#
?
Aug 25, 2020 00:35
|
|
|
*months pass* please rebase onto current master thanks
|
|
#
?
Aug 25, 2020 00:39
|
|
|
this does not agree with my vision for the project.
|
|
#
?
Aug 25, 2020 01:19
|
|
|
what’s a pr
|
|
#
?
Aug 25, 2020 01:20
|
|
|
not much, what’s a pr with you
|
|
#
?
Aug 25, 2020 01:37
|
|
|
my stepdads beer posted:*months pass* please rebase onto current master thanks this
|
|
#
?
Aug 25, 2020 01:45
|
|
|
i never squash my commits and i only do ff merges gently caress everyone
|
|
#
?
Aug 25, 2020 02:44
|
|
|
I just merged in something that breaks all of your changes, op. rebasing is not going to help. sorry.
|
|
#
?
Aug 25, 2020 02:52
|
|
|
sales guy here. i kinda promised the customer this would all be sorted out by tomorrow. can you guys do me a solid and bang this one out?
|
|
#
?
Aug 25, 2020 03:30
|
|
|
President Beep posted:sales guy here. i kinda promised the customer this would all be sorted out by tomorrow. can you guys do me a solid and bang this one out? hold on, the product team needs to pass this by our data scientist first to make sure we get proper tracking
|
|
#
?
Aug 25, 2020 03:44
|
|
|
President Beep posted:what’s a pr a miserable pile of commits
|
|
#
?
Aug 25, 2020 03:47
|
|
|
Hi. I see this PR "replace an n³ nested loop with a much faster linear approach" claims to be a performance improvement. Performance PRs will not be merged without concrete data showing an improvement. Please run the performance tests and link the results. *performance tests fail to compile because nobody has run them in years*
|
|
#
?
Aug 25, 2020 03:54
|
|
|
also, nested loop go brrrrr
|
|
#
?
Aug 25, 2020 03:56
|
|
|
sounds like a premature optimization. do we know this is a real problem?
|
|
#
?
Aug 25, 2020 04:14
|
|
|
hey we should probably test this, can you architect a test framework and continuous integration system? thanks.
|
|
#
?
Aug 25, 2020 04:46
|
|
|
President Beep posted:what’s a pr pull request. something us code janitors do
|
|
#
?
Aug 25, 2020 05:03
|
|
|
my sla for prs is one week from date of submission so I still have 3 days to complete it
|
|
#
?
Aug 25, 2020 05:58
|
|
|
You're supposed to put the Jira key at the end of the PR title. Changes requested.
|
|
#
?
Aug 25, 2020 06:07
|
|
|
why did the contiguous integration build fail in a totally unrelated component on a machine this code doesn’t even run on? please investigate
|
|
#
?
Aug 25, 2020 08:27
|
|
|
read the style guide
|
|
#
?
Aug 25, 2020 10:16
|
|
|
I know you only made a one line change but please refactor this whole function
|
|
#
?
Aug 25, 2020 15:03
|
|
|
remove the comments. code should be self documenting
|
|
#
?
Aug 25, 2020 15:08
|
|
|
please document this code. I can see it increments num_transactions_processed_successfully, but why?
|
|
#
?
Aug 25, 2020 15:42
|
|
|
Bored Online posted:remove the comments. code should be self documenting 
|
|
#
?
Aug 25, 2020 18:01
|
|
|
:shipit:
|
|
#
?
Aug 25, 2020 18:17
|
|
|
i’m gonna send you 10 comments asking you to change some variable names and won’t read the code other than that
|
|
#
?
Aug 25, 2020 18:33
|
|
|
|
| # ? Apr 18, 2024 10:43 |
|
|
the first line is unrelated to the supporting ticket, please submit again with only the second line
|
|
#
?
Aug 25, 2020 18:54
|
|