JawKnee fucked around with this message at 10:23 on Feb 1, 2016

rjmccall fucked around with this message at 11:44 on Feb 1, 2016

#include <iostream>
#include <cstdlib>
#include <ctime>
using namespace std;

int main()
{
	// Declare variables
	srand(time(0));
	int randNumOne, randNumTwo, randNumThree, randNumFour;
	int randNumGen();

    
    randNumOne=randNumGen();
    
    randNumTwo=randNumGen();
    while (randNumTwo == randNumOne)
    randNumTwo=randNumGen();
    
    randNumThree=randNumGen();
    while (randNumThree == randNumTwo || randNumThree == randNumOne)
    randNumThree=randNumGen();
    
    randNumFour=randNumGen();
    while (randNumFour == randNumThree || randNumFour == randNumTwo || randNumFour == randNumOne)
    randNumFour=randNumGen();

    cout << randNumOne << " " << randNumTwo << " " << randNumThree << " " << randNumFour;
	return 0;
}
	
int randNumGen()

{
    int randNum=0;
	randNum = (rand() % 25 + 1);
	return randNum;
}

Scrapez fucked around with this message at 17:20 on Feb 1, 2016

Malcolm XML fucked around with this message at 19:40 on Feb 2, 2016

template <typename Callable>
bool api_controller::call_sub_controller(Callable&& cb,const Request& request, Response& response)
{
  auto identifier = get_controller_identifier(request); 
  auto controller = sub_controllers.find(identifier);
  bool found = (controller != sub_controllers.end());
  if( found )
  {
    auto new_req = request;
    new_req.uri = get_controller_uri(request);
    ((controller->second.get())->*cb)(new_req,response); //here I call the overridden method of whatever controller has been registered for that identifier
  }
  return found;
}

//and I call it like this
void api_controller::method1(const Request& request, Response& response)
{
  if(!call_sub_controller(&base_controller::method1,request,response)) // here I dispatch to the appropriate sub controller, and if I cannot find one, call the base class
  {
    base_controller::method1(request,response);    
  }
}

template <typename Callable,typename Req,typename...Arguments>
bool api_controller::call_sub_controller(Callable&& cb,const Req& request, Arguments....params)
{
//code as  before...
    ((controller->second.get())->*cb)(new_req,params);
//....
}
//and I call it as before

void api_controller::method1(const Request& request, Response& response)
{
  if(!call_sub_controller(&base_controller::method1,request,response)) // here I dispatch to the appropriate sub controller, and if I cannot find one, call the base class
  {
    base_controller::method1(request,response);
  }
}

template <typename Callable>
void api_controller::call_sub_controller(Callable&& cb,const Request& request, Response& response)
{
  auto ident = get_controller_identifier(request);
  auto controller = sub_controllers.find(ident);
  bool found = (controller != sub_controllers.end());
  if( found )
  {
    auto new_req = request;
    new_req.uri = get_controller_uri(request);
    ((controller->second.get())->*cb)(new_req,response);
  }
  else
  {
	(this->*cb)(request,response);
  }
}

Volguus fucked around with this message at 14:45 on Feb 9, 2016

• Some syntax errors, which should be causing compile errors: 4 dots instead of 3 in the function signature, and no dots after params in the function pointer call
  
• Functions don't appear to be inline, which all template functions should be (although they might be declared as such in the class body, but that's not the usual way of doing it). If they're not inline, there might be undiagnosed ODR violations.
  
• Not using perfect forwarding; not a matter of correctness here, but might as well do it.
  

template <typename Callable,typename Req,typename...Arguments>
inline bool api_controller::call_sub_controller(Callable&& cb,const Req& request, Arguments&&...params)
{
//code as  before...
    ((controller->second.get())->*cb)(new_req, std::forward<Arguments>(params)...);
//....
}
//and I call it as before

Volguus fucked around with this message at 00:57 on Feb 11, 2016