|
My favorite thing to point out about code coverage is that you can delete all the asserts and expects from your tests, so they test nothing, and still get the same code coverage percentage.
|
#
?
Nov 13, 2018 04:35
|
|
|
|
| # ? May 9, 2024 03:54 |
|
|
Yes, it’s true. Code coverage can’t single-handedly compensate for gross incompetence.
|
|
#
?
Nov 13, 2018 04:56
|
|
|
I've written for platforms that don't support any sort of testing and it's horrible. I'm very pro testing, I just don't like writing pointless ones to get coverage back to X% because another dev wrote a 400 line function with no coverage for the third time this sprint.
|
|
#
?
Nov 13, 2018 05:14
|
|
|
I am working on a patent for a mechanical arm that goes around your throat. As you code more and more, the arm squeezes tighter. Only by adding good tests does the arm release its grip.
|
|
#
?
Nov 13, 2018 05:23
|
|
|
SardonicTyrant posted:release its grip. I think I found a bug in your scheme
|
|
#
?
Nov 13, 2018 05:55
|
|
|
SardonicTyrant posted:I am working on a patent for a mechanical arm that goes around your throat. As you code more and more, the arm squeezes tighter. Only by adding good tests does the arm release its grip. Nobody speak^H^H^H^H^H write, nobody get choked. https://www.youtube.com/watch?v=NUC2EQvdzmY
|
|
#
?
Nov 13, 2018 06:13
|
|
|
Code coverage, like any metric, is useless all by itself without any other context. Almost none of the actual problems we've had at my company in production would have been caught by that level of thinking about unit tests. Code coverage doesn't say anything about the quality of the tests done nor the gaps in test and system design. The only metrics that seem to be leading indicators is asking "how confident would you feel about refactoring X class and deploying it straight into production after it passed tests?"
|
|
#
?
Nov 13, 2018 07:27
|
|
|
Eggnogium posted:Yes, it’s true. Code coverage can’t single-handedly compensate for gross incompetence. I tried having this conversation with previous boss and the concept never quite stuck.
|
|
#
?
Nov 13, 2018 07:38
|
|
|
Pedestrian Xing posted:I've written for platforms that don't support any sort of testing and it's horrible. I'm very pro testing, I just don't like writing pointless ones to get coverage back to X% because another dev wrote a 400 line function with no coverage for the third time this sprint. How did it get into master? Are you one of those shops that don't do reviews before merge?  Fundamentally, coverage is there to help guide people acting in good faith. If you have programmers who act in bad faith, just loving fire them.
|
|
#
?
Nov 13, 2018 08:01
|
|
|
Volmarias posted:I think I found a bug in your scheme
|
|
#
?
Nov 13, 2018 13:24
|
|
|
Xarn posted:If you have programmers who act in bad faith, just loving fire them. Unless you work at my company where it can take weeks to hire a candidate (and the candidates usually find another position while they wait), so they don't fire any of the programmers they do have, even if they are grossly incompetent. I have never seen such poorly formatted and clearly copy-pasted from StackOverflow style code in a production application until I worked with some of the developers on my scrum team. But beyond raising my concerns in a code review and talking to my manager about it, I can't really do anything else. Until an eventual bug is filed in the code and I get to refactor it, of course. In good news they gave me two 10+ percent raises this year, which makes it a lot easier to deal with the BS, since now I can afford more whiskey. Macichne Leainig fucked around with this message at 15:10 on Nov 13, 2018 |
|
#
?
Nov 13, 2018 15:08
|
|
|
Protocol7 posted:Unless you work at my company where it can take weeks to hire a candidate (and the candidates usually find another position while they wait), so they don't fire any of the programmers they do have, even if they are grossly incompetent. Sounds like you should get a 50% raise by going to another company that doesn't refuse to fire idiots and save the whiskey money too.
|
|
#
?
Nov 13, 2018 15:15
|
|
|
Volmarias posted:Sounds like you should get a 50% raise by going to another company that doesn't refuse to fire idiots and save the whiskey money too. I have one of those jobs where I can spend most of my time doing a second job that's more fulfilling. So, while my actual "employment" job is a bit poo poo, it still pays 80 grand a year, has amazing insurance and 401k match, and I make $35/hour on the side for about 20 hours a week.
|
|
#
?
Nov 13, 2018 16:23
|
|
|
Code coverage + mutation testing seems pretty good in my experience. You are still left with the problem of tests testing for the wrong thing, but at the very least it helps make your tests actually test the code instead of just running the code
|
|
#
?
Nov 13, 2018 16:24
|
|
|
Protocol7 posted:I have one of those jobs where I can spend most of my time doing a second job that's more fulfilling. So, while my actual "employment" job is a bit poo poo, it still pays 80 grand a year, has amazing insurance and 401k match, and I make $35/hour on the side for about 20 hours a week. So... $115k. That's like entry level Good Tech Job, not counting RSUs.
|
|
#
?
Nov 13, 2018 17:47
|
|
|
Volmarias posted:So... $115k. I don't know of any entry-level positions that pay 6 digits. Every junior level position I've seen in my area pays around 55-60k.
|
|
#
?
Nov 13, 2018 18:21
|
|
|
Protocol7 posted:I don't know of any entry-level positions that pay 6 digits. Every junior level position I've seen in my area pays around 55-60k. Can you move out of the rust belt?
|
|
#
?
Nov 13, 2018 18:58
|
|
|
Volmarias posted:So... $115k. Agreed. gently caress your life; drop everything and move to silicon valley where you can make a sweet 6.06 figgies w/ a bit of stock working 100+ hours a week for a world-changing startup like uber-for-furniture or tinder-for-cats or mumble-mumble-machine-learning with a scam artist/investor and a bunch of early-20s techbros.
|
|
#
?
Nov 13, 2018 19:28
|
|
|
redleader posted:Agreed. gently caress your life; drop everything and move to silicon valley where you can make a sweet 6.06 figgies w/ a bit of stock working 100+ hours a week for a world-changing startup like uber-for-furniture or tinder-for-cats or mumble-mumble-machine-learning with a scam artist/investor and a bunch of early-20s techbros. Uh oh, did I strike a nerve?
|
|
#
?
Nov 13, 2018 19:30
|
|
|
Protocol7 posted:Unless you work at my company where it can take weeks to hire a candidate (and the candidates usually find another position while they wait), so they don't fire any of the programmers they do have, even if they are grossly incompetent. Well then, don't work there  Seriously though, if I am interviewing and the company doesn't have a good answer to "do you have a CI and what are you criteria for failing a commit/merging a PR", I keep looking.
|
|
#
?
Nov 13, 2018 19:34
|
|
|
Volmarias posted:Can you move out of the rust belt? No need to, I live in a city with reasonable housing costs so I don't need a 100k base salary just to be able to pay rent on a lovely 600 sq foot studio. Also I live in Colorado which has a decent tech industry and the base salary is still around 60k. Xarn posted:Well then, don't work there The criteria are good on paper, there are just a few poo poo devs that instead of expending effort on learning how to write good code find some ways to game the system a bit (by always approving each other's PRs, et cetera.) I could quit and find another job that pays probably 10k more, but I lose out on some good benefits and then I'd have a real job with real daily responsibilities, and I do enjoy getting paid to bitch about my job on SA. Macichne Leainig fucked around with this message at 20:06 on Nov 13, 2018 |
|
#
?
Nov 13, 2018 20:03
|
|
|
Code coverage as a metric can be objectively useful as a way to catch if someone accidentally forgot to test a branch or area of code. Annotate any code that shouldn't or can't be covered in tests for whatever reason and make sure you have 100% code coverage everywhere else.
|
|
#
?
Nov 13, 2018 21:18
|
|
|
SardonicTyrant posted:I am working on a patent for a mechanical arm that goes around your throat. As you code more and more, the arm squeezes tighter. Only by adding good tests does the arm release its grip. Haha! Using TDD I made the arm loosen its grip enough to escape entirely!
|
|
#
?
Nov 13, 2018 21:40
|
|
|
Doom Mathematic posted:Haha! Using TDD I made the arm loosen its grip enough to escape entirely! User Story: Feature Enhancement: Allow maximum grip to be configurable on installation. A manager at one of our customers has advised that a couple of their developers found a way to escape the arm by writing tests before the implementation in new solutions. This story is to allow a customer to set the maximum grip size when installing the arm to a chair/desk.
|
|
#
?
Nov 13, 2018 23:14
|
|
|
Don't you mean minimum grip?
|
|
#
?
Nov 14, 2018 06:36
|
|
|
Doom Mathematic posted:Haha! Using TDD I made the arm loosen its grip enough to escape entirely! Allow test failures to tighten grip as well. 
|
|
#
?
Nov 14, 2018 17:15
|
|
|
Keetron posted:Don't you mean minimum grip? Yeah I hosed up, maximum would be how tight the grip is rather then how lose it is which is what I was going for. I'll book in a quick 45 minute meeting with the team to discuss.
|
|
#
?
Nov 14, 2018 18:46
|
|
|
Xik posted:Yeah I hosed up, maximum would be how tight the grip is rather then how lose it is which is what I was going for. I'll book in a quick 45 minute meeting with the team to discuss. *forwards the invitation to six people who have a stake in the minimum grip* Are you sure 45 minutes is enough? After everyone accepted and a shitfest is already in emails about the best arm length: "Sorry man, I thought you meant the *other* Thursday, the one in the meeting invite I am having my ears waxed so I cannot make it." Lessons learned: never invite me for meetings.
|
|
#
?
Nov 14, 2018 19:27
|
|
|
We need to make sure we include the teams from New York and Arizona because they are looking at making their own changes to grip. Make sure you get a video conference going. Probably push it to at least 2 hours long to be safe.
|
|
#
?
Nov 14, 2018 19:32
|
|
|
Legal just got back to us and apparently our right-hand-only design is a violation of government accessibility regulations and they're saying we need to spin up a separate project to build a left-handed gripper. For budgetary reasons this effort will be done by our offshore team.
|
|
#
?
Nov 14, 2018 19:54
|
|
|
We'll need to add them to that call. Find a time that works for New York, Arizona, Pakistan, and Moscow.
|
|
#
?
Nov 14, 2018 20:03
|
|
|
Drop the gripping arm, and make it a leash/belt/garrote. Eliminates most accessibility concerns, and also enables possible expansion to attach central line IV inputs at the jugular. E: Which means we should probably pull in marketing to see if that has any appeal, or if there's any better form-factor.
|
|
#
?
Nov 14, 2018 20:07
|
|
|
Clanpot Shake posted:Legal just got back to us and apparently our right-hand-only design is a violation of government accessibility regulations and they're saying we need to spin up a separate project to build a left-handed gripper. For budgetary reasons this effort will be done by our offshore team. 
|
|
#
?
Nov 14, 2018 20:43
|
|
|
darthbob88 posted:Drop the gripping arm, and make it a leash/belt/garrote. Eliminates most accessibility concerns, and also enables possible expansion to attach central line IV inputs at the jugular. Make sure the new version is backwards compatible, we have some legacy clients who are using the arms as nutcrackers and we don't want to break their applications when they upgrade
|
|
#
?
Nov 14, 2018 20:58
|
|
|
To allow backward compatibility we should use the existing arm to tighten a belt.
|
|
#
?
Nov 14, 2018 21:15
|
|
|
ChickenWing posted:Make sure the new version is backwards compatible, we have some legacy clients who are using the arms as nutcrackers and we don't want to break their applications when they upgrade
|
|
#
?
Nov 14, 2018 21:16
|
|
|
Add machine learning so it can learn coding styles and adjust grip strength accordingly.
|
|
#
?
Nov 14, 2018 21:20
|
|
|
*in a very 2017 voice* have we explored putting this on the blockchain?
|
|
#
?
Nov 14, 2018 21:47
|
|
|
Suffocation as a Service
|
|
#
?
Nov 14, 2018 21:54
|
|
|
|
| # ? May 9, 2024 03:54 |
|
|
Can this be implemented in Node.js though? This way our web developers can help out when it's crunch time!
|
|
#
?
Nov 14, 2018 22:08
|
|